commit 48326ee2e2462d32f53bd38c2a3cff4fce89ef99
author Ryan Macnak <rmacnak@google.com> Wed Feb 16 23:44:30 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Feb 16 23:44:30 2022 +0000
tree add7aaab36db5086f987cbee6a299138a33f7f5c
parent 04d61d01b576d291d99db3846b61e66eb8aaf2fe

[vm, compiler] Fix accessing unboxed double parameters in the presence of optional parameters on RV32.

Apparently LoadIndexedUnsafe expects kWordSize scaling even when accessing doubles. Cf. ARM32.

TEST=bigint_from_test
Bug: https://github.com/dart-lang/sdk/issues/48333
Change-Id: I21e300feabec28d763f2b679db5656f5dd0f0ea6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233420
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>

runtime/vm/compiler/backend/il_riscv.cc

diff --git a/runtime/vm/compiler/backend/il_riscv.cc b/runtime/vm/compiler/backend/il_riscv.cc
index c9067af..51aa2b4 100644
--- a/runtime/vm/compiler/backend/il_riscv.cc
+++ b/runtime/vm/compiler/backend/il_riscv.cc
@@ -132,8 +132,7 @@
     }
     case kUnboxedDouble: {
       const auto out = locs()->out(0).fpu_reg();
-      const intptr_t kDoubleSizeLog2 = 3;
-      __ slli(TMP, index, kDoubleSizeLog2 - kSmiTagSize);
+      __ slli(TMP, index, kWordSizeLog2 - kSmiTagSize);
       __ add(TMP, TMP, base_reg());
       __ LoadDFromOffset(out, TMP, offset());
       break;