tree 7afd3284f2f53f347c150e4f48caa88df5912c44
parent 2d8410eada9bd34742b105449519f7e6ce8e2bc5
author Johnni Winther <johnniwinther@google.com> 1653997653 +0000
committer Commit Bot <commit-bot@chromium.org> 1653997653 +0000

[cfe] Use [BlockExpression] to encode named function expressions

Previously a named function expression (function declaration occurring
in an expression context) was encoded using a
[NamedFunctionExpressionJudgment] which was a specialization of a [Let]
expression. This encoding couldn't handle recursive calls occurring in
the body of the named function expression, since the let variable
is not available in the initializer of the let variable, leading to
a crash in serialization.

This CL changes the encoding to use a [BlockExpression] instead and
deletes the [NamedFunctionExpressionJudgment] node.

Closes https://github.com/dart-lang/sdk/issues/49122

Change-Id: I40c5535624b2d8933a6f400c927ba42b028f7a29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246445
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>