[deps] Roll jsshell & firefox to newer version
Firefox performs more strict validation when enabling the `js-string`
builtin. Namely it requires the wasm array to `fromCharCodeArray` to be
nullable (as per-spec), where D8 is more lenient and allows non-nullable
wasm array just fine.
Issue https://github.com/dart-lang/sdk/issues/59899
Change-Id: I22f2add0eacfaa4265011ca5f47cac92642b69d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/404300
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
diff --git a/DEPS b/DEPS
index 1c9ad44..73acaa0 100644
--- a/DEPS
+++ b/DEPS
@@ -72,7 +72,7 @@
# instructions. d8, the V8 shell, is always checked out.
"checkout_javascript_engines": False,
"d8_tag": "version:13.4.32",
- "jsshell_tag": "version:133.0",
+ "jsshell_tag": "version:134.0",
"jsc_tag": "version:288804",
# https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang
@@ -174,7 +174,7 @@
"download_chrome": False,
"chrome_tag": "132.0.6834.83",
"download_firefox": False,
- "firefox_tag": "133.0.3",
+ "firefox_tag": "134.0",
# Emscripten is used in dart2wasm tests.
"download_emscripten": False,
diff --git a/sdk/lib/_internal/wasm/lib/js_helper_patch.dart b/sdk/lib/_internal/wasm/lib/js_helper_patch.dart
index 1ddd5e8..0b8aae1 100644
--- a/sdk/lib/_internal/wasm/lib/js_helper_patch.dart
+++ b/sdk/lib/_internal/wasm/lib/js_helper_patch.dart
@@ -61,7 +61,7 @@
@pragma("wasm:import", "wasm:js-string.fromCharCodeArray")
external WasmExternRef _jsStringFromCharCodeArray(
- WasmArray<WasmI16> array,
+ WasmArray<WasmI16>? array,
WasmI32 start,
WasmI32 end,
);
