| commit | e4ff34ceac0bdf59e5193c3b0220ef5bed4b6724 | [log] [tgz] |
|---|---|---|
| author | Daco Harkes <dacoharkes@google.com> | Mon Oct 11 16:27:20 2021 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Mon Oct 11 16:27:20 2021 +0000 |
| tree | 2fafaec3514f2f0127733cf496be36d44d1dda8a | |
| parent | 5f95f4d3bbe719281f7e5ced63040942dafc6cc3 [diff] |
[vm] Defer Field::RecordStore in Deserialization Field::RecordStore inspects the object being pointed to. However, it is not guaranteed that that objects has been initialized in *DeserializationCluster::ReadEdges, that depends on the order of the clusters. In the reproduction, the TypedDataView cluster comes after the cluster containing the instance. This leads to doing a field store while the length field of the TypedDataView has not been read yet and is 0. This causes a Field::RecordStore with value 0, which subsequently gets used in compilation causing RangeErrors. This CL delays the Field::RecordStore from ReadEdges to PostLoad so that all objects are initialized before they are inspected by RecordStore. TEST=tests/language/vm/regress_flutter_89584_test.dart Fixes: https://github.com/flutter/flutter/issues/89584 Change-Id: I1d5fe25c4084d62d5e492446123987aee10200bb Cq-Include-Trybots: luci.dart.try:vm-kernel-optcounter-threshold-linux-release-x64-try,vm-kernel-linux-debug-x64-try,vm-kernel-mac-debug-x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-linux-debug-x64c-try,vm-kernel-reload-linux-debug-x64-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-nnbd-win-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216181 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.