| commit | 12b1773deba18ce53e7e2c53ef5b2d44e3e85476 | [log] [tgz] |
|---|---|---|
| author | Vyacheslav Egorov <vegorov@google.com> | Wed Nov 17 12:12:31 2021 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Nov 17 12:12:31 2021 +0000 |
| tree | 29994e3832cc6a1abfeafc274f6d3140ff01a051 | |
| parent | bfbcfa6dc5fd5ae8966469e56ab6f00fa3129ef6 [diff] |
[vm] Fix issues with flutter_regress_91370_il_test * Add Canonicalize pass after CSE to erase graph differences between 64-bit and 32-bit platforms. These differences originate from different treatment of integers (we unbox more eagerly on 64-bit platform) and consequently affect load forwarding - which generates some redundant[1] phis on 64-bit platform, but not on 32-bit platform. Adding this pass also addresses other cases of unpredictable performance when IL changes can cause CSE not to trigger a Canonicalize inside itself and regress performance, by inhibiting subsequent optimizations. * Allow IL tests to check whether the graph was compiled in sound null safety mode or not - because graphs can have minor differences. * Use `"$i"` instead of `i.toString()` in the test to allow TFA to infer non-nullability of fields in non-sound-nullsafety mode. [1] The definition of redundant phi differs between canonicalization pass and load forwarding pass. The former unwraps redefinitions and the latter does not. We are going to address this difference in a more systematic way when we split input dependencies from control dependencies. TEST=ci Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-release-simarm-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm_x64-try Change-Id: Ifbd68fbb7f3b374ecee8ada1b3a4a2249139a108 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220541 Commit-Queue: Slava Egorov <vegorov@google.com> Reviewed-by: Daco Harkes <dacoharkes@google.com>
Dart is:
Optimized for UI: Develop with a programming language specialized around the needs of user interface creation.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app.
Fast on all platforms: Compile to ARM & x64 machine code for mobile, desktop, and backend. Or compile to JavaScript for the web.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.