| commit | 425e07d721e53d92e9662f5a8bd1e1e76d6ac068 | [log] [tgz] |
|---|---|---|
| author | Konstantin Shcheglov <scheglov@google.com> | Wed Feb 14 20:43:13 2018 +0000 |
| committer | commit-bot@chromium.org <commit-bot@chromium.org> | Wed Feb 14 20:43:13 2018 +0000 |
| tree | c0fe45bef55aaec69cca7141d1c628709ea2d9a2 | |
| parent | 933a0ae895464fcfad21655954632fc8e73faba5 [diff] |
If selection in 'Extract Method' does not cover any node, extract the smallest covering expression. Two comments. 1. We need also to change the Dart plugin for IntelliJ to not select the whole line when selection if empty. The whole line is almost never a good choice for Flutter. 2. This is not fully consistent with "Extract Lolal" where we give the client the list of possible expressions to extract and the user can then choose. Here we use just the smallest one. If we want to make it consistent, we will need to enchance the protocol and the plugin. R=brianwilkerson@google.com, devoncarew@google.com Change-Id: I87a752234d9c825d78a6d787d2b21d1b252166c2 Reviewed-on: https://dart-review.googlesource.com/41520 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Dart is an open-source, scalable programming language, with robust libraries and runtimes, for building web, server, and mobile apps.
Visit the dartlang.org to learn more about the language, tools, getting started, and more.
Browse pub.dartlang.org for more packages and libraries contributed by the community and the Dart team.
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents on our wiki.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.