commit 0e1d24ae80d2411578ce07dac34a03028cae9d98
author Ilya Yanok <yanok@google.com> Wed Aug 17 12:29:03 2022 +0000
committer Commit Bot <commit-bot@chromium.org> Wed Aug 17 12:29:03 2022 +0000
tree 2ad6a49ac72a4acb1d8386072de11d95600c688d
parent 8ba4a714a512ed7680527f3d6aa293dfd7e75acf

Revert "[dart2js] Enable flag (canary -> shipping) to intern dart type values."

This reverts commit e833510bc5b34c3d6437265e42f34abae1f9f022.

Reason for revert: breaks many tests in G3, see b/242822389

Original change's description:
> [dart2js] Enable flag (canary -> shipping) to intern dart type values.
>
> Change-Id: Iebac3a7c57665eccd100146f892b891a4591f554
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255201
> Reviewed-by: Stephen Adams <sra@google.com>
> Commit-Queue: Stephen Adams <sra@google.com>

TBR=sra@google.com,natebiggs@google.com

Change-Id: I9b2be8fc119f84f33181245cdfce416d13660daf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/255401
Reviewed-by: Ilya Yanok <yanok@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ilya Yanok <yanok@google.com>

pkg/compiler/lib/src/options.dart

diff --git a/pkg/compiler/lib/src/options.dart b/pkg/compiler/lib/src/options.dart
index 6c8d90d..25a334b 100644
--- a/pkg/compiler/lib/src/options.dart
+++ b/pkg/compiler/lib/src/options.dart
@@ -105,7 +105,6 @@
   late final List<FeatureOption> shipping = [
     useContentSecurityPolicy,
     deferredSerialization,
-    internValues,
   ];
 
   /// [FeatureOption]s which default to disabled.
@@ -114,6 +113,7 @@
     newDumpInfo,
     simpleAsyncToFuture,
     cfeConstants,
+    internValues,
   ];
 
   /// Forces canary feature on. This must run after [Option].parse.

pkg/compiler/test/dump_info/data/deferred/main.dart

diff --git a/pkg/compiler/test/dump_info/data/deferred/main.dart b/pkg/compiler/test/dump_info/data/deferred/main.dart
index b900353..b562e90 100644
--- a/pkg/compiler/test/dump_info/data/deferred/main.dart
+++ b/pkg/compiler/test/dump_info/data/deferred/main.dart
@@ -104,7 +104,7 @@
   "id": "outputUnit/1",
   "kind": "outputUnit",
   "name": "1",
-  "size": 1112,
+  "size": 1087,
   "filename": "out_1.part.js",
   "imports": [
     "lib"

pkg/compiler/test/dump_info/data/deferred_future/main.dart

diff --git a/pkg/compiler/test/dump_info/data/deferred_future/main.dart b/pkg/compiler/test/dump_info/data/deferred_future/main.dart
index 5cfb182..0d5b68a 100644
--- a/pkg/compiler/test/dump_info/data/deferred_future/main.dart
+++ b/pkg/compiler/test/dump_info/data/deferred_future/main.dart
@@ -110,7 +110,7 @@
   "id": "outputUnit/1",
   "kind": "outputUnit",
   "name": "1",
-  "size": 895,
+  "size": 870,
   "filename": "out_1.part.js",
   "imports": [
     "lib1"