| // Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file |
| // for details. All rights reserved. Use of this source code is governed by a |
| // BSD-style license that can be found in the LICENSE file. |
| |
| import 'package:analyzer/src/error/codes.dart'; |
| import 'package:test_reflective_loader/test_reflective_loader.dart'; |
| |
| import '../dart/resolution/context_collection_resolution.dart'; |
| |
| main() { |
| defineReflectiveSuite(() { |
| defineReflectiveTests(UnnecessaryImportTest); |
| }); |
| } |
| |
| @reflectiveTest |
| class UnnecessaryImportTest extends PubPackageResolutionTest { |
| test_annotationOnDirective() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class A { |
| const A() {} |
| } |
| '''); |
| await assertNoErrorsInCode(r''' |
| @A() |
| import 'lib1.dart'; |
| '''); |
| } |
| |
| test_as() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| class B {} |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'lib1.dart'; |
| import 'lib2.dart' as two; |
| f(A a, two.B b) {} |
| '''); |
| } |
| |
| test_as_differentPrefixes() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| class B {} |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'lib1.dart' as one; |
| import 'lib2.dart' as two; |
| f(one.A a, two.B b) {} |
| '''); |
| } |
| |
| test_as_equalPrefixes_referenced() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', r''' |
| class B {} |
| '''); |
| await assertNoErrorsInCode(r''' |
| import 'lib1.dart' as one; |
| import 'lib2.dart' as one; |
| f(one.A a, one.B b) {} |
| '''); |
| } |
| |
| test_as_equalPrefixes_referenced_via_export() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', r''' |
| class B {} |
| '''); |
| newFile('$testPackageLibPath/lib3.dart', r''' |
| export 'lib2.dart'; |
| '''); |
| await assertNoErrorsInCode(r''' |
| import 'lib1.dart' as one; |
| import 'lib3.dart' as one; |
| f(one.A a, one.B b) {} |
| '''); |
| } |
| |
| test_as_equalPrefixes_unreferenced() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', r''' |
| class B {} |
| '''); |
| await assertNoErrorsInCode(r''' |
| import 'lib1.dart' as one; |
| import 'lib2.dart' as one; // ignore: unused_import |
| f(one.A a) {} |
| '''); |
| } |
| |
| test_as_show_multipleElements() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class A {} |
| class B {} |
| '''); |
| await assertNoErrorsInCode(r''' |
| import 'lib1.dart' as one show A, B; |
| f(one.A a, one.B b) {} |
| '''); |
| } |
| |
| test_as_showTopLevelFunction() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class One {} |
| topLevelFunction() {} |
| '''); |
| await assertNoErrorsInCode(r''' |
| import 'lib1.dart' hide topLevelFunction; |
| import 'lib1.dart' as one show topLevelFunction; |
| f(One o) { |
| one.topLevelFunction(); |
| } |
| '''); |
| } |
| |
| test_as_showTopLevelFunction_multipleDirectives() async { |
| newFile('$testPackageLibPath/lib1.dart', r''' |
| class One {} |
| topLevelFunction() {} |
| '''); |
| await assertNoErrorsInCode(r''' |
| import 'lib1.dart' hide topLevelFunction; |
| import 'lib1.dart' as one show topLevelFunction; |
| import 'lib1.dart' as two show topLevelFunction; |
| f(One o) { |
| one.topLevelFunction(); |
| two.topLevelFunction(); |
| } |
| '''); |
| } |
| |
| test_as_systemShadowing() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class File {} |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'dart:io' as io; |
| import 'lib1.dart' as io; |
| g(io.Directory d, io.File f) {} |
| '''); |
| } |
| |
| test_as_unnecessary() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| class B {} |
| '''); |
| await assertErrorsInCode(''' |
| import 'lib1.dart' as p; |
| import 'lib2.dart' as p; |
| f(p.A a, p.B b) {} |
| ''', [ |
| error(HintCode.UNNECESSARY_IMPORT, 7, 11), |
| ]); |
| } |
| |
| test_class_deprecatedExport() async { |
| newFile('$testPackageLibPath/a.dart', ''' |
| class A {} |
| '''); |
| |
| newFile('$testPackageLibPath/b.dart', ''' |
| library; |
| @deprecated |
| export 'a.dart'; |
| class B {} |
| '''); |
| |
| await assertNoErrorsInCode(''' |
| import 'a.dart'; |
| import 'b.dart'; |
| void f(A a, B b) {} |
| '''); |
| } |
| |
| test_duplicateImport_differentPrefix() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| class B {} |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'lib1.dart'; |
| import 'lib1.dart' as p; |
| f(A a1, p.A a2, B b) {} |
| '''); |
| } |
| |
| test_extension_equalPrefixes_unnecessary() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| extension E1 on int { |
| void foo() {} |
| } |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| extension E2 on int { |
| void bar() {} |
| } |
| '''); |
| await assertErrorsInCode(''' |
| import 'lib1.dart' as prefix; |
| import 'lib2.dart' as prefix; |
| void f() { |
| 0.foo(); |
| 0.bar(); |
| } |
| ''', [ |
| error(HintCode.UNNECESSARY_IMPORT, 7, 11), |
| ]); |
| } |
| |
| test_extension_noPrefixes_necessary() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| extension E1 on int { |
| void foo() {} |
| } |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| extension E2 on int { |
| void bar() {} |
| } |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'lib1.dart'; |
| import 'lib2.dart'; |
| void f() { |
| 0.foo(); |
| 0.bar(); |
| } |
| '''); |
| } |
| |
| test_extension_noPrefixes_unnecessary() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| extension E1 on int { |
| void foo() {} |
| } |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| extension E2 on int { |
| void bar() {} |
| } |
| '''); |
| await assertErrorsInCode(''' |
| import 'lib1.dart'; |
| import 'lib2.dart'; |
| void f() { |
| 0.foo(); |
| 0.bar(); |
| } |
| ''', [ |
| error(HintCode.UNNECESSARY_IMPORT, 7, 11), |
| ]); |
| } |
| |
| test_hide() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart' hide A; |
| class B {} |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'lib1.dart'; |
| import 'lib2.dart'; |
| f(A a, B b) {} |
| '''); |
| } |
| |
| test_systemShadowing() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class File {} |
| '''); |
| await assertNoErrorsInCode(''' |
| import 'dart:io'; |
| import 'lib1.dart'; |
| g(Directory d, File f) {} |
| '''); |
| } |
| |
| test_unnecessaryImport() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| class B {} |
| '''); |
| await assertErrorsInCode(''' |
| import 'lib1.dart'; |
| import 'lib2.dart'; |
| f(A a, B b) {} |
| ''', [ |
| error(HintCode.UNNECESSARY_IMPORT, 7, 11), |
| ]); |
| } |
| |
| test_unnecessaryImport_sameUri() async { |
| newFile('$testPackageLibPath/lib1.dart', ''' |
| class A {} |
| '''); |
| newFile('$testPackageLibPath/lib2.dart', ''' |
| export 'lib1.dart'; |
| class B {} |
| '''); |
| await assertErrorsInCode(''' |
| import 'dart:async'; |
| import 'dart:async' show Completer; |
| f(FutureOr<int> a, Completer<int> b) {} |
| ''', [ |
| error(HintCode.UNNECESSARY_IMPORT, 28, 12), |
| ]); |
| } |
| } |