commit 018ad19e3efffaf7188093cad8b0868734ebfd4f
author Konstantin Shcheglov <scheglov@google.com> Mon Jun 02 16:28:22 2025 -0700
committer Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jun 02 16:28:22 2025 -0700
tree fbe937fe3340d26903328bcd0a9b3c8a6cf8ce7f
parent 338a83af8925036cbc24bd8c298d9b091513e6f6

Elements. Make LibraryFragment not Annotatable.

Change-Id: I17e0a952b513cfdce81f8404d625f723f6dad95b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

pkg/analyzer/CHANGELOG.md

diff --git a/pkg/analyzer/CHANGELOG.md b/pkg/analyzer/CHANGELOG.md
index 0639019..91e8b6f 100644
--- a/pkg/analyzer/CHANGELOG.md
+++ b/pkg/analyzer/CHANGELOG.md
@@ -5,6 +5,7 @@
 * Remove deprecated `RecordType.sortedNamedTypes`.
 * Remove `ElementLocation` class; its values are not returned anymore.
 * Remove deprecated `AnalysisContext.analysisOptions`.
+* `LibraryFragment` is not `Annotatable` anymore.
 * Deprecate `element2.dart` library; import `element.dart`.
 * Deprecate `XyzElement2` classes; use `XyzElement` instead.
 * Deprecate `AnalysisError.correction` field; use

pkg/analyzer/api.txt

diff --git a/pkg/analyzer/api.txt b/pkg/analyzer/api.txt
index 511e20f..536876e 100644
--- a/pkg/analyzer/api.txt
+++ b/pkg/analyzer/api.txt
@@ -3544,7 +3544,7 @@
     combinators (getter: List<NamespaceCombinator>)
     exportKeywordOffset (getter: int)
     exportedLibrary2 (getter: LibraryElement?)
-  LibraryFragment (class extends Object implements Fragment, Annotatable):
+  LibraryFragment (class extends Object implements Fragment):
     new (constructor: LibraryFragment Function())
     accessibleExtensions2 (getter: List<ExtensionElement>)
     classes2 (getter: List<ClassFragment>)

pkg/analyzer/lib/dart/element/element.dart

diff --git a/pkg/analyzer/lib/dart/element/element.dart b/pkg/analyzer/lib/dart/element/element.dart
index d4c8586..479ebd4 100644
--- a/pkg/analyzer/lib/dart/element/element.dart
+++ b/pkg/analyzer/lib/dart/element/element.dart
@@ -2534,7 +2534,7 @@
 }
 
 /// The portion of a [LibraryElement] coming from a single compilation unit.
-abstract class LibraryFragment implements Fragment, Annotatable {
+abstract class LibraryFragment implements Fragment {
   /// The extension elements accessible within this fragment.
   List<ExtensionElement> get accessibleExtensions2;
 

pkg/analyzer/lib/src/dart/element/element.dart

diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index e8fea16..d6eede5 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -6245,10 +6245,6 @@
   @override
   final LibraryElementImpl library;
 
-  @override
-  // TODO(scheglov): Why is it even annotatable?
-  final MetadataImpl metadata = MetadataImpl(const []);
-
   /// The libraries exported by this unit.
   List<LibraryExportImpl> _libraryExports = _Sentinel.libraryExport;
 
@@ -6500,10 +6496,6 @@
   @override
   Source get librarySource => library.source;
 
-  @Deprecated('Use metadata instead')
-  @override
-  MetadataImpl get metadata2 => metadata;
-
   List<MixinFragmentImpl> get mixins {
     return _mixins;
   }

pkg/analyzer/test/src/summary/element_text.dart

diff --git a/pkg/analyzer/test/src/summary/element_text.dart b/pkg/analyzer/test/src/summary/element_text.dart
index 69c2182..5695719 100644
--- a/pkg/analyzer/test/src/summary/element_text.dart
+++ b/pkg/analyzer/test/src/summary/element_text.dart
@@ -1291,8 +1291,6 @@
       _writeFragmentReference('previousFragment', f.previousFragment);
       _writeFragmentReference('nextFragment', f.nextFragment);
 
-      _writeMetadata(f.metadata);
-
       if (configuration.withImports) {
         var imports =
             f.libraryImports2.where((import) {