| commit | a73598b5f36cf32c2d498391c6b9e7b015c02a4f | [log] [tgz] |
|---|---|---|
| author | Nehal Patel <nehalvpatel@users.noreply.github.com> | Wed Nov 09 09:07:36 2022 -0800 |
| committer | GitHub <noreply@github.com> | Wed Nov 09 18:07:36 2022 +0100 |
| tree | c08b4a7fc1efd21d88b311d40f509960672a8778 | |
| parent | 5527068c31a3b92beb8f9bfe0953ff9580b3dc86 [diff] |
Refactor HTTP retries (#3325) (#3590) * Break out networking related OS error codes * Add mapException feature to retry util * Add WIP sendWithRetries method * Fix potential runtime null response in onRetry option * Remove code to get CI working * Apply suggestions from code review Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com> * Update Pub HTTP exceptions * Remove stack trace from retry methods * Remove hard-coded domain check for HTTP 500 * Simplify method * Align retry behavior with requirements * Move withAuthenticatedClient a layer up and clarify comment * Clarify usage of global HTTP client * Take request metadata out of _PubHttpClient * Use RetryClient for OAuth2 calls * Retrigger checks * Wrap versions HTTP call with retryForHttp * Add more comments * Use "throwIfNotOk" in versions HTTP call * Change PackageIntegrityException to always subclass as an intermittent PubHttpException * Configure OAuth2 HTTP retries * Make metadata headers method an extension on http.Request and use .throwIfNotOk() in more places * Add retries to OIDC discovery document request * Add some retries to upload command * Add retries to upload package step * Fix indentation * Make PubHttpResponseException use BaseResponse * Fix get_test * Fix more tests * Fix SHA-256 tests * Only send pub.dev API Accept header when necessary and fix tests Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Pub is the package manager for Dart.
Thanks for being interested in contributing to pub! Contributing to a new project can be hard: there's a lot of new code and practices to learn. This document is intended to get you up and running as quickly as possible. For more information, see the pub tool documentation.
The first step towards contributing is to contact the pub dev team and let us know what you‘re working on, so we can be sure not to start working on the same thing at the same time. Open an issue letting us know that you’re interested in contributing and what you plan on working on. This will also let us give you specific advice about where to start.
Pub isn‘t a package, but it’s organized like one. It has four top-level directories:
lib/ contains the implementation of pub. Currently, it's all in lib/src/, since there are no libraries intended for public consumption.
test/ contains the tests for pub.
bin/ contains pub.dart, the entrypoint script that's run whenever a user types “pub” on the command line or runs it in the Dart editor. This is usually run through shell scripts in sdk/bin at the root of the Dart repository.
It's probably easiest to start diving into the codebase by looking at a particular pub command. Each command is encapsulated in files in lib/src/command/.
To run pub from the Git repository, run:
dart bin/pub.dart
Before any change is made to pub, all tests should pass. To run a pub test, run:
dart tool/test.dart test/path/to_test.dart
To run all tests at once, run:
dart tool/test.dart
Changes to pub should be accompanied by one or more tests that exercise the new functionality. When adding a test, the best strategy is to find a similar test in test/ and follow the same patterns.
Pub tests come in two basic forms. The first, which is usually used to unit test classes and libraries internal to pub, has many tests in a single file. This is used when each test will take a short time to run. For example, test/version_test.dart contains unit tests for pub's Version class.
The other form, used by most pub tests, is usually used for integration tests of user-visible pub commands. Each test has a file to itself, which is named after the test description. This is used when tests can take a long time to run to avoid having the tests time out when running on the build bots. For example, tests/get/hosted/get_transitive_test.dart tests the resolution of transitive hosted dependencies when using dart pub get/flutter pub get.
All patches to official Dart packages, including to pub, need to undergo code review before they're submitted. The full process for putting up your patch for review is documented elsewhere.