tree 9f60a77b67f2758f52b49dd8de50c571709e8209
parent a1820273b9f3c7bb5a13d26cd14d30d5bab187ae
author Jonas Finnemann Jensen <jonasfj@google.com> 1579002649 +0100
committer GitHub <noreply@github.com> 1579002649 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJeHasZCRBK7hj4Ov3rIwAAdHIIAISuespBrjonuD2JCXgC4NNL
 W/bFnmaA13skd7+2t1mHO353cD121MYrwVoDtgAgJXFvnyelGKVFYE7YwEMpcr3N
 Uf2jceH5ApW104Dh84uxygKJ1waEuTyVG++wRhuWx8Y2kx+YioBLriIv1G9GUPyo
 UN9SOx9jPkXmwKweoISmMvcoqVMXOkT376AVw14d/l3D6Eh91yNZXFlX47tr9A6v
 SnlgQ2Qj4D8eWSHs+1gw4Svp1ZYuBengm853A8hl9+a6BJ0kT7BR82ouNRQU9yQI
 4GxRv7FmB1T494BuxgUjPy6aq7X4tR7aN9sRlDVu//c/AVQ1K67E6ZiUMSPbaP8=
 =vK/X
 -----END PGP SIGNATURE-----
 

Retry on all SocketExceptions (#2254)

Do not retry on OS specific error codes for `SocketException`.
These OS error codes are not documented in the code, and they
may change behavior depending on OS and architecture.

Furthermore, many seemingly persistent errors such as DNS lookup
failures should be retried.

Finally, if we retry a `SocketException` unnecessarily this is of
little impact. It means that if the user doesn't have a network
connection, or tries to use a `PUB_HOSTED_URL` pointing to a
non-existent pub server, then it will take a bit longer before
the user is informed of the problem.