tree e74ca526e93580f7e96cfa2f3c4919a355dc3402
parent 376c9ce480536ad84572e087e35f31ff931627bc
author Ömer Sinan Ağacan <omersa@google.com> 1747301626 +0200
committer GitHub <noreply@github.com> 1747301626 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJoJbT6CRC1aQ7uu5UhlAAAn8kQAExIF+txH/8q1KryLhIN8/Qd
 Q6/PW30/EfyHIDF5FLQlsopKcCb5D+7OIWpTn4hNtw+dfFVJhSgWwWI4WgZGMwKz
 eg6hyumtd6TCkYS75/ZXxrgZaxdVC4kKPG/H7B2b6viK70ZhovstMbyt5wf2fgiq
 5dZYSa3SrtG3D59ibIjOOk8dns/DP1EGost0HRt16PKO6o3stL8er5rnESBThdUf
 /5+sNSX4zBhJevDqmwwU4WtwLBoQ0KAff+PNWc1fQHIEfGgDDb+NCjxbUJXAZ+ob
 RPjQKFv9S3+mMJIWDmz8MFO7avP+EPskJQTn5SmJxTf4f+dOwa00FggB7H78bcZx
 UiidygABUFh0WmRRC/veMdYg0d33chptzg95Q6efziZOKrI4x29tzbBz9aZ1VyDR
 K+V0p9ho2Xv6OSF0C48QR0kPLIsj8r107z8vQrX2ZltwYaQ5l5kU0VDnx6ky1Pog
 gJq8nwYqwC63iVfLwjocsEXzF7bmo/UmjiJ8mwgLUBx53Z0850EFZpExqVo3oCOs
 L82UTCmYeejKQ0gSzDSr4cX1GP+owit5vUrr3tt0+yJcu93kAsm0pKOlJ7UxRECm
 jrwF7jwBwFbIhm1J41JYKrao4r4fLSNKYK+MahVTDu552AFtYBUcIl95QPs88Pf5
 8269WQlPAJ1AVz2rtL1E
 =s7xC
 -----END PGP SIGNATURE-----
 

Improve enum decoding -- alternative (#981)

When decoding an enum value, we call a callback in the enum field's `FieldInfo`. The callback then indexes a map mapping enum numbers to Dart values.

When these conditions hold:

- The known enum numbers are all positive. (so that we can use a list and index it with the number)

- The known enum numbers are more than 70% of the large known enum number. (so that the list won't have a lot of `null` entries, wasting heap space)

We now generate a list instead of a map to map enum numbers to Dart values.

Similar to the map, the list is runtime allocated. No new code generated per message or enum type.

AOT benchmarks:

- Before: `protobuf_PackedEnumDecoding(RunTimeRaw): 47585.14 us.`
- After: `protobuf_PackedEnumDecoding(RunTimeRaw): 38974.566666666666 us.`
- Diff: -18%

Wasm benchmarks:

- Before: `protobuf_PackedEnumDecoding(RunTimeRaw): 52225.0 us.`
- After: `protobuf_PackedEnumDecoding(RunTimeRaw): 34283.33333333333 us.`
- Diff: -34%

**Alternatives considered:**

- #980 uses a map always, but eliminates the `valueOf` closure.
- #985 uses a list always, and does binary search in the list when the list is "shallow".
- #987 is the same as #985, but instead of calling the `valueOf` closure it stores an extra field in `FieldInfo`s for whether to binary search or directly index.

These are all slower than the current PR.