commit 4ec722ab0dbdae7a9f77510b427ac751df8b604a
author Loren Van Spronsen <lorenvs@outlook.com> Thu Apr 21 02:12:06 2022 -0700
committer GitHub <noreply@github.com> Thu Apr 21 11:12:06 2022 +0200
tree 0ec13f280589eb7a08a2a9249ec84fdc1f14bf9b
parent b96dc211e16a074bb03abc41f2d893d24bf6692b

Correctly combine hash codes for repeated enums. (#556)

The existing logic in `hashField` is overriding the previously computed
hash codes, which could include values from other fields within the
message. Any message with a repeated enum field with a (relatively) high
tag number will generate a poor hash code which doesn't reflect other
fields.

Co-authored-by: Loren Van Spronsen <lorenvs@google.com>

protobuf/lib/src/protobuf/field_set.dart

diff --git a/protobuf/lib/src/protobuf/field_set.dart b/protobuf/lib/src/protobuf/field_set.dart
index a7879cd..9800563 100644
--- a/protobuf/lib/src/protobuf/field_set.dart
+++ b/protobuf/lib/src/protobuf/field_set.dart
@@ -668,7 +668,8 @@
       } else if (!_isEnum(fi.type)) {
         hash = _HashUtils._combine(hash, value.hashCode);
       } else if (fi.isRepeated) {
-        hash = _HashUtils._hashObjects(value.map((enm) => enm.value));
+        hash = _HashUtils._combine(
+            hash, _HashUtils._hashObjects(value.map((enm) => enm.value)));
       } else {
         ProtobufEnum enm = value;
         hash = _HashUtils._combine(hash, enm.value);