Fix widget inspector control layout and add safe area regression test (#180789) ### Description This PR fixes Widget Inspector controls not respecting system safe area insets. Previously, the inspector control buttons were positioned without accounting for system UI insets (such as gesture navigation bars), which could cause them to overlap or be partially obscured by system UI. This change updates the Widget Inspector control layout to respect `MediaQuery.viewPadding` when positioning the controls. Importantly, the safe area handling is scoped only to the inspector controls themselves, so the previewed application and inspector selection overlay continue to occupy the full available screen and remain selectable in unsafe areas. A regression test is added to ensure preview content is not inset when `viewPadding` is present. ### Issues fixed * Fixes Widget Inspector controls overlapping system UI due to missing safe area handling. * Ensures preview content is not inset when inspector controls respect system safe areas. *(No existing issue was filed; this was identified during review. Happy to link one if preferred.)* ### Tests * Added a widget test verifying that preview content is not inset when `MediaQuery.viewPadding` is applied. ## Pre-launch Checklist * [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. * [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. * [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. * [x] I signed the [CLA]. * [x] I listed at least one issue that this PR fixes in the description above. * [x] I updated/added relevant documentation (doc comments with `///`) where appropriate. * [x] I added new tests to check the change I am making. * [x] I followed the [breaking change policy] (no breaking changes). * [x] All existing and new tests are passing. ## Beofre Fix <img width="1080" height="2400" alt="533829007-5aba7be7-e8bd-47f4-9d64-38e1ab1a0c6b" src="https://github.com/user-attachments/assets/d4f6c193-75a2-4c55-9a80-9a60e5e58f0c" /> ## After Fix <img width="1080" height="2400" alt="Screenshot_1768012272" src="https://github.com/user-attachments/assets/8fe9f5e3-8c2a-4eec-9a14-6e2dbb19a5c4" /> --------- Co-authored-by: Elliott Brooks <21270878+elliette@users.noreply.github.com> https://dart.googlesource.com/external/github.com/flutter/flutter/+/5e1be56d2e9d25a77e2d5351ecc74a48765b8010
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.