Revert "Reland "Reland "[dart2wasm] Include wasm-opt in the shipped dart-sdk.""" This reverts commit faecf41be154eef7a59453c202052eaa3479ff7c. Reason for revert: Flutter HHH bots are broken: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8788949281966049297/+/u/build_host_debug/stdout Original change's description: > Reland "Reland "[dart2wasm] Include wasm-opt in the shipped dart-sdk."" > > This is a reland of commit b19091385aea21b19ee0a069b0e1bad8fe008f48 > > Fixed the calculation of the paths of binaryen source files so that they > work properly when building as a dependency (inside the flutter engine > repo). > > Original change's description: > > Reland "[dart2wasm] Include wasm-opt in the shipped dart-sdk." > > > > This is a reland of commit 6271d26baf498ab2b053c52527bc65f7f43e802b > > > > The change broke the gcc riscv64 builders, due to a `unused-variable` > > warning coming from binaryen sources. That warning has now been > > disabled for binaryen targets. > > > > Original change's description: > > > [dart2wasm] Include wasm-opt in the shipped dart-sdk. > > > > > > Change-Id: Ib224f0b92fa28019ad3cf67d7ba2bef5c31b92ef > > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280840 > > > Reviewed-by: Martin Kustermann <kustermann@google.com> > > > Commit-Queue: Jackson Gardner <jacksongardner@google.com> > > > Reviewed-by: Aske Simon Christensen <askesc@google.com> > > > > Change-Id: I76bf4ad5d1f6a8116631df4b91cbc5a52cac4f31 > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283240 > > Reviewed-by: Martin Kustermann <kustermann@google.com> > > Commit-Queue: Jackson Gardner <jacksongardner@google.com> > > Change-Id: I5cc269daebc5e2068c084bb72b2bd7cb58ba6fbe > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283721 > Reviewed-by: Martin Kustermann <kustermann@google.com> > Commit-Queue: Jackson Gardner <jacksongardner@google.com> TBR=kustermann@google.com,askesc@google.com,joshualitt@google.com,jacksongardner@google.com,dart-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If4e864b3dfb5d9ff840846bff0690247256b2762 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283745 Reviewed-by: Jackson Gardner <jacksongardner@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com> https://dart.googlesource.com/sdk/+/e3661b7d2f9d94899bd057ece13a439583418230
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.