| commit | df58f4917dedbc43fcb3b0b3c439c4edf895f946 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Wed Apr 17 18:30:20 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Apr 17 11:32:11 2024 -0700 |
| tree | e0fd58946d9141d883bb5fafd96770df4a780c87 | |
| parent | 443026624efbae02fd39f50828b32cb9960e9156 [diff] |
[vm] Simplify root unit checks in snapshot deserialization. Previously, there were two ways to determine whether a deserialization cluster was being deserialized for the root loading unit or a non-root loading unit: * some deserialization clusters (those deriving from CanonicalSetDeserializationCluster) took a boolean at construction time, and * all deserialization clusters took an additional boolean argument to ReadFill and PostLoad on whether the loading unit was primary (i.e., the root) or not. Since only clusters that deal with canonical values need to worry about whether the deserializing loading unit is the root or not, standardize on the first, where clusters that need to know take the boolean in their constructor and store it in a field, and remove the boolean argument to ReadFill and PostLoad. Have DeserializationCluster::PostLoad just check is_canonical() to determine whether to throw an error if not overridden in the base class, so that any deserialization cluster that may operate on canonical objects needs to explicitly make a choice about whether they need to recanonicalize or not. This check only happens in the precompiled runtime, as otherwise there are no non-root loading units. In particular, this fixes an issue where symbols (canonical strings) in non-root loading units weren't marked as canonical, even though they do not need recanonicalization (since symbol tables are per-isolate group, and thus per-loading unit). TEST=ci (refactoring, test of symbol fix coming in followup CL) Cq-Include-Trybots: luci.dart.try:vm-aot-dwarf-linux-product-x64-try,vm-aot-linux-release-x64-try,vm-aot-linux-debug-x64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-product-arm64-try Change-Id: I411a254767653da82631abc1fcc687ae4259e0b4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363321 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> https://dart.googlesource.com/sdk/+/2d49ca0204caaee8a6a076d7c0ed2f4d8658b0bc
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.