| commit | da68cdaa3c151e18ff0b1c36c3c77594b3391f7d | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Tue Aug 27 19:03:02 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Tue Aug 27 12:03:50 2024 -0700 |
| tree | d1e146938ed42aadb92601e0c234bedf88352e30 | |
| parent | 13d71d79584f77cfd1a22c7cc8efbdd69b602b64 [diff] |
Reland "[vm] Improvements in the BitField API." This is a reland of commit bfc1a445273ee21ad80d3cb52597a4606b591233 Change how the partial specializations for AtomicBitFieldContainer are written so that Visual Studio properly chooses them instead of the base BitField template when appropriate. TEST=Windows ARM64 CI trybots Original change's description: > [vm] Improvements in the BitField API. > > If no position is specified, then the bitfield starts at bit 0. > > The default size for bool BitFields is 1 instead of the remaining > bits in the container. > > If the size of the value type is smaller than the remaining bits > in the container, then the size of the value type is used as > the default size instead. > > If a signed value is used in a non-sign-extended BitField, only > the magnitude of the value is stored, not the sign bit. This means > the actual size of the bitfield may be one less than the requested > size in this case. > > If the requested size of the bitfield is larger than the size of the > value type, a compile-time error is thrown. (For signed types, the > requested size is allowed to be the size of the entire value, even if > only the magnitude bits are stored.) > > Rework uses of BitFields to avoid using separate constants for > bit positions/sizes except for macro-defined bitfields (which now > are universally bool, and so size 1). > > TEST=vm/cc/BitFields_Defaults > > Change-Id: I40711c929d2e5165ce40823772beb49e8cfdb820 > Cq-Include-Trybots: luci.dart.try:vm-aot-dwarf-linux-product-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-release-x64-try,vm-aot-mac-release-arm64-try,vm-aot-linux-release-simarm_x64-try > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381644 > Reviewed-by: Ryan Macnak <rmacnak@google.com> > Commit-Queue: Tess Strickland <sstrickl@google.com> Change-Id: I5e3a9e3e2a80d5689a23a0603f8f81fac1576cd3 Cq-Include-Trybots: luci.dart.try:vm-aot-dwarf-linux-product-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-linux-release-x64-try,vm-aot-mac-release-arm64-try,vm-aot-linux-release-simarm_x64-try,vm-win-debug-x64c-try,vm-win-release-x64-try,vm-aot-win-release-x64-try,vm-win-release-arm64-try,vm-aot-win-release-arm64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382383 Auto-Submit: Tess Strickland <sstrickl@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> https://dart.googlesource.com/sdk/+/d3c165d7b52e48672224d0e46d2c74696fd89322
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.