[flow analysis] Improve how catch clauses are modeled in tests. This change updates the mini_ast testing infrastructure so that: - It properly models the "exception type" part of a catch clause (the type named after the `on` keyword). - It requires an exception variable to be specified if there is a stack trace variable (this is required by the Dart grammar). - It requires an exception type to be specified if there is no exception variable (this is required by the Dart grammar). - During the "pre-visit" stage, the exception variable and stack trace variable are registered with the `AssignedVariables` object, so that they can be properly handled by type promotion. - During the main "visit" stage, the exception variable and stack trace variable are assigned the appropriate types. Flow analysis unit tests are updated in order to meet the new requirements, and flow analysis tests are added to check that stack trace and exception variables are promotable and appropriately typed. By ensuring that stack trace and exception variables are properly typed during flow analysis tests, this paves the way for some follow-up work, in which I plan to re-work how flow analysis keeps track of variable types. There is no behavioral change to the analyzer or compiler pipeline; these changes are confined to `pkg/_fe_analyzer_shared/test`. Change-Id: I49c4b894d82d1dc58d62e3d3f25d232c9106922e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434145 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> https://dart.googlesource.com/sdk/+/a226405a70c31a418be2243487d8d3882fa5e03e
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.