| commit | bce3eb8d4a4d88f10708aa23252896587932be02 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Fri Oct 04 13:44:40 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Fri Oct 04 06:46:47 2024 -0700 |
| tree | ecd5fe07e15204374a945136f946564d53985b0a | |
| parent | 05be806c3ccaddfb8226d1995d729ed4d04f7203 [diff] |
[flow analysis] Remove ExpressionInfo.after. Previously, the base `ExpressionInfo` class contained four fields: - `type`: the type of the expression. - `ifTrue`: a flow model describing the state of the program after the expression is evaluated, assuming the expression evaluates to `true`. - `ifFalse`: a flow model describing the state of the program after the expression is evaluated, assuming the expression evaluates to `false`. - `after`: a flow model describing the state of the prorgam after the expression is evaluated, making no assumptions about what value the expression evaluates to. The `after` field was largely redundant, since it tracked the same information as `FlowAnalysisImpl._current`. In fact, flow analysis contained a substantial amount of code to copy from `ExpressionInfo.after` to `FlowAnalysisImpl._current`, or vice versa, in order to keep the two in sync. The one exception was in `FlowAnalysisImpl.conditional_end`, which is called at the end of visiting a conditional expression (`e1 ? e2 : e3`): it joined the `after` flow models from `e2` and `e3` in order to determine the state of the program after the conditional expression completes. To preserve this behavior, a small amount of extra accounting logic had to be added to the handling of conditional expressions, to keep track of these flow models. (`e2.after` is now stored in `_ConditionalContext.thenModel`, and `e3.after` comes from the state of `_current` at the time of entry into `FlowAnalysisImpl.conditional_end`). Change-Id: I46e771f8b029550d43a5fe50366177f189a6a91d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388081 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Kallen Tu <kallentu@google.com> https://dart.googlesource.com/sdk/+/38c08f919d0e9c0cfabfcd04af797e091f0bbaac
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.