| commit | b1582b88decb38dc2396c4b013fd681b95f17459 | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Wed Oct 25 13:54:38 2023 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Oct 25 06:56:50 2023 -0700 |
| tree | b82ab23cc92e1431c9abf144e04ea4efa5ca2212 | |
| parent | e0bfce445624b34afbf21e9a0909e008c50fd8e7 [diff] |
[vm/compiler] Fix range analysis for IntConverter. Before, converting a Uint32 to a Int32 would just clamp the range to be within the possible Int32 range. However, that's not what the IntConverterInstr represents in this case: in this case, it's just a reinterpretation of the bits as signed instead of unsigned. For simplicity's sake, the initial fix for this is to keep the range [x, y] if it is 0 <= x <= y <= kMaxInt32, and otherwise just use the full Int32 range. Also add a version of Range::Full that takes a Representation instead of a RangeSize, so that the ranges for unsigned unboxed ints can be made more precise. Previously, they'd be overapproximated by the next largest signed representation instead. Also check that we're never trying to create a range for x->untagged, and that untagged->x just uses the full range for x. TEST=vm/dart/regress_306327173_il_test Fixes: b/306327173 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-simarm_x64-try,vm-aot-linux-release-x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try Change-Id: Ic60d24be016844deda56ee477a6950a315b8506f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332040 Commit-Queue: Tess Strickland <sstrickl@google.com> Reviewed-by: Slava Egorov <vegorov@google.com> https://dart.googlesource.com/sdk/+/87f62aedaddf6614ba994ece28851dae434a6554
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.