Avoid permanently paused isolates These tests have some exceptions caused by missing fields on the dynamic variable. The exceptions cause the `isolate.resume()` call to not run, which also cause the test body to not complete. Currently this is masked by the test runner, which immediately ignores the test body once the first error occurs. That behavior is changing, and a failure will not immediately end a test when the body is still running. https://github.com/dart-lang/test/pull/1815 Some of these tests are currently are expected to fail, but not to timeout. Fix the test implementations to more reliably complete the test body, even when the test had an error. This does not fix the tests themselves, it maintains the current pattern of failure, even after updating the test runner. - Use `Stream.firstWhere` over cancelling the stream subscription after the first breakpoint. - Use `Future.whenComplete` to ensure the isolate is always unpaused, including after an exception in the expectations. Tested: Passes with updated test runner in https://dart-review.googlesource.com/c/sdk/+/275401/4 Change-Id: If5a7f0264c580cb38bcc1bd95c035aaf5644124b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275787 Auto-Submit: Nate Bosch <nbosch@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> https://dart.googlesource.com/sdk/+/f065dca391c93f017f7bfc79ce8280c73c34452b
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.