| commit | abbd4d47f64453b9202641638e8f170c1d4178fb | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Thu Apr 03 11:56:51 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Thu Apr 03 12:07:50 2025 -0700 |
| tree | 8034c3b5154c6324cc46352b0641879b344947bc | |
| parent | 35552ccfa4551cd1f09d2e04f668e27e864da628 [diff] |
[_fe_analyzer_shared] Use TypeAnalyzerOptions to configure flow analysis. Previously, flow analysis was configured by passing a set of named booleans to its constructor, each to enable or disable a separate language feature. This change merges the flow analysis configuration with the `TypeAnalyzerOptions` class (which was already being used for configuring the shared `TypeAnalyzer` class). This should make it easier to add language features to the shared code base in the future, since there will be one common place where all features will be configured. To avoid duplicating the logic that creates `TypeAnalyzerOptions`, I've had to do a bit of minor surgery to the clients: - In the test harness in `_fe_analyzer_shared`, there is a common method (`Harness.computeTypeAnalyzerOptions`) that constructs `TypeAnalyzerOptions` based on the harness configuration. It is called from a few different tests. - In `pkg/analyzer`, there is a common method (`computeTypeAnalyzerOptions`) that constructs `TypeAnalyzerOptions` based on a `FeatureSet`. It is used by `LibraryAnalyzer.analyzeForCompletion`, `LibraryAnalyzer._resolveFile`, and the late variable `AstResolver._typeAnalyzerOptions`. - In `pkg/front_end`, I've moved computation of `TypeAnalyzerOptions` from the `InferenceVisitorImpl` constructor to the `TypeInferrerImpl` constructor; the options are then passed to the `InferenceVisitorImpl` by `_createInferenceVisitor`. I'm doing this work now as preparation for adding support for sound flow analysis (https://github.com/dart-lang/sdk/issues/60438), so that I can add the logic to enable it in a clean way. Bug: https://github.com/dart-lang/sdk/issues/60438 Change-Id: Ib845194adb404b4c0a3feeff17a14ae641d515eb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419940 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/08154451d592311947a9cbe025238892efd3f320
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.