| commit | a46a6ac755f062f3961cdb8fabad4baa8e286fd4 | [log] [tgz] |
|---|---|---|
| author | Srujan Gaddam <srujzs@google.com> | Tue Aug 20 03:33:56 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Aug 19 20:35:48 2024 -0700 |
| tree | 35c4670d19e34337904503649babcb5b5e7d58f4 | |
| parent | bc279244e8a3edd8420e7b0cdf5f64b7b85fb744 [diff] |
Reland "[dart:js_interop] Add Since('3.6') annotations to new APIs"
This reverts commit 7600900d78793a9c7177963eb3f30cd74edc5903.
Reason for revert: https://github.com/flutter/engine/pull/54626 has update the pubspecs for web_ui and web_sdk to include `3.6`.
Original change's description:
> Revert "[dart:js_interop] Add Since('3.6') annotations to new APIs"
>
> This reverts commit 14cf3b44d3e705c7ae1b450044c151f7f8a49c70.
>
> Reason for revert: web_ui uses some of these APIs, but the pubspec SDK version is not >= 3.6. Therefore, Flutter analyze fails, which would then result in a broken roll. Updating the pubspec versions leads to try bot failures (https://github.com/flutter/engine/pull/54590) so for now, revert.
>
> Original change's description:
> > [dart:js_interop] Add Since('3.6') annotations to new APIs
> >
> > Closes https://github.com/dart-lang/sdk/issues/56484
> >
> > Change-Id: I9d3da568aafeccbb855892ea5c2ba647371170bc
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380900
> > Reviewed-by: Kevin Moore <kevmoo@google.com>
> > Reviewed-by: Leaf Petersen <leafp@google.com>
> > Reviewed-by: Sigmund Cherem <sigmund@google.com>
> > Commit-Queue: Srujan Gaddam <srujzs@google.com>
> > Reviewed-by: Martin Kustermann <kustermann@google.com>
>
> Change-Id: Idfb021c5744d83a8004259f9c8774945a2612efd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380967
> Reviewed-by: Leaf Petersen <leafp@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Srujan Gaddam <srujzs@google.com>
Change-Id: I5c37640e06456d270db2adfd70283456bde671ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381308
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
https://dart.googlesource.com/sdk/+/ed6c00c2f0b5854b2ca52bacaaa05fe672822aba
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.