| commit | a09a2119c21f4244bfb0599c68680fd3bc8b8cd9 | [log] [tgz] |
|---|---|---|
| author | Lasse R.H. Nielsen <lrn@google.com> | Wed Feb 21 13:05:56 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Feb 21 05:07:28 2024 -0800 |
| tree | dfab0e0cb87d0e42daea938fe7b372645a884d23 | |
| parent | 1ebf6f09b6fa18c0cd8e5c44092a3cf1d7b9b31a [diff] |
Forwards `ignore` bit to chained-to `_Future`. If a target `_Future` is chained to another source `_Future`, then it's because the target will complete with the same result as the source future. Instead of keeping both alive with a listener on the source which completes the target, instead the target moves all its listeners to be directly on the source, and keeps a link to the source in case more listeners are added later. The idea is that most futures are unreferenced after they have had their first listener, so the target future has a chance to be GC'ed. If the target future has `.ignore()` called, and has no listener, then the source completing with an error should not cause the error to be uncaught. Without the optimization, the source would have had a listener, and the target would ignore the error. To simulate that, the source now gets a copy of the target's `_ignoreUnhandledErrors` flag. This is still not precisely the same as it would be without the optimization. If *two* target futures are chained to the same source, and only one of targes has `.ignore()` called, then this implementation will make the uncaught error not be reported, where it technically should. (An alternative would be to *not* use chaining for futures with `ignore()` called on them. But those are precisely futures that are likely to be GC'able, because someone has already said that they don't care if the future complete with errors.) Fixes #54943 Bug: https://github.com/dart-lang/sdk/issues/54943 Change-Id: I0dbb4919ce2ea612d66539862fa0eb188aab8287 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352908 Reviewed-by: Slava Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com> Reviewed-by: Stephen Adams <sra@google.com> https://dart.googlesource.com/sdk/+/e86b08e5bb869baf0a05d249f05459442088b86a
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.