| commit | a043e17fb7964a422a13ece6909b3b127ba96843 | [log] [tgz] |
|---|---|---|
| author | Sam Rawlins <srawlins@google.com> | Thu May 30 22:49:39 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Thu May 30 15:52:10 2024 -0700 |
| tree | a91b2b9f12f02c334b2f34f232d569be75084c38 | |
| parent | e7491a05ac81989c35dd2d0946341e41c71990ee [diff] |
DAS: Make _AbstractCorrectionProducer._context non-late, final. We do this by passing a CorrectionProducerContext up each of the constructors. We can then remove all `configure` methods. This requires a few changes and allows a few changes: * Remove ParsedCorrectionProducer. It does not seem to have served a purpose. * CorrectionProducerContext no longer needs to be generic. * Add a public getter for `MultiCorrectionProducer._context`, so that a multi correction producer can pass along its context to child correction producers. * Introduce a `CorrectionProducerContext.instance` dummy variable, used when we need to check if a correction producer can be applied in bulk. * Make `CorrectionProducerContext._node` public, so that it can be used in factory constructors. * `BulkFixProcesor.correctionContext()` return type is non-nullable. * Add a factory constructor for AddMissingParameter, and move the `configure` logic there. * Add a factory constructor for ConvertAddAllToSpread, and move the `configure` logic there. Then make `_isInlineInvocation` and `_invocation` final. * Add a factory constructor for ReplaceFinalWithVar, and move the `configure` logic there. Then make `_removeFinal` and `_finalKeyword` final. * Add a factory constructor for ReplaceWithIsEmpty, and move the `configure` logic there. Then make `fixKind`, `multiFixKind`, `_binary`, and `_replacement` final. * Rename `_AddMissingParameter.context` to `_executableParameters`, and make it final. Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try Change-Id: If0e9bc1cbf5c8e656938bc6cd4eb32a9d4f06b38 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368760 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> https://dart.googlesource.com/sdk/+/ebd8c46b8558e56f16c71591996d889ec807d415
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.