| commit | 9dab08e32375903c16add40836c4e144804a6f81 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Tue Jun 03 17:10:44 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Tue Jun 03 17:12:22 2025 -0700 |
| tree | 16c7742f1d56bd8766517d67d35f2a4cef28e3f7 | |
| parent | 6b6ba5d687811e40fbe4fb1fc80f16b59a6b665e [diff] |
[flow analysis] In tests, stop rewriting ordinary variable declarations. During the implementation of flow analysis for patterns, I added a hack to the flow analysis tests so that all variable declarations were desugared into the equivalent pattern variable declaration. This had the advantage of getting some extra testing "for free" during early development of the patterns feature, but it had a few disadvantages: - It the caused the shared flow analysis and type inference tests to stop exercising flow analysis code paths for ordinary variable declarations. - It forced the testing logic to "support" pattern variable declarations that are late or lack an initializer; these are things that regular Dart doesn't support, and they made the implementation of `PatternVariableDeclaration.visit` much more complicated than it needed to be. The language team is currently contemplating some changes to how promotions work in ordinary variable declarations and pattern variable declarations (see, for example, https://github.com/dart-lang/language/issues/4347#issuecomment-2861859329). So in order to be able to experiment with these possibilities, I want to get rid of this hack. This CL adds a `VariableDeclaration` class, to represent ordinary variable declarations, and modifies the `declare` function (which is used by tests for creating an ordinary variable declaration) so that it creates a `VariableDeclaration`, rather than rewriting it into a `PatternVariableDeclaration` containing a `VariablePattern`. It removes "support" for testing pattern variable declarations that are late or lack an initializer, simplifying `PatternVariableDeclaration.visit`. A few test cases in `type_inference_test.dart` were checking the generated IR for ordinary variable declarations, verifying that it was properly desugared into a pattern variable declaration; these expectations have accordingly changed to no longer expect desugaring. There is no functional change to the compiler or analyzer toolchain. These changes only affect tests in `pkg/_fe_analyzer_shared/test`. Change-Id: I90f074cd6e7a6ed5ed11afadeadb6131ce1d282f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432122 Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com> https://dart.googlesource.com/sdk/+/b0e488fcb25db14b5586c5093e00e427e7a54f9d
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.