Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions) (#46636)

Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions)

https://skia.googlesource.com/skia.git/+log/d86da2a029d8..2f67f1f18562

2023-10-06 kjlubick@google.com Add dedicated function to calculate length of Base64 encoded string
2023-10-06 bungeman@google.com [pathops] Simplify trivial paths to empty
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 44a79902f2c1 to 01742293d0f2 (11 revisions)
2023-10-06 johnstiles@google.com Add fuzzer for SkSL-to-WGSL.
2023-10-06 johnstiles@google.com Add fuzzer for runtime blenders.
2023-10-06 johnstiles@google.com Add fuzzer for runtime color filters.
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a42cebae4e42 to ac72499c0a8a (91 revisions)
2023-10-06 kjlubick@google.com Split codec-related parts out of tools/Resources.h
2023-10-06 drott@chromium.org [Fontations] Borrow glyph mask flag implementation from FreeType
2023-10-06 jvanverth@google.com Try to fix Dawn roll again.
2023-10-06 drott@chromium.org [Fontations] FFI Interface for accessing CPAL and COLRv0 info
2023-10-06 jvanverth@google.com Disable Tint's use of //build directory to fix Dawn roll
2023-10-06 johnstiles@google.com Add workaround for dropped clear in VKDMSAA.
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3d75b794df0f to 8c341cfdef74 (3 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46c5d45d5955 to 44a79902f2c1 (15 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e12f70e0a324 to 8d9cef29be25 (3 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 535363447183 to 8d9cef29be25
2023-10-06 jvanverth@google.com [graphite] Revise PathAtlas::onAddShape interface.
2023-10-05 lovisolo@google.com [bazel] BazelBenchmarkRunner.cpp: Write results.json output file in Perf's new JSON format.
2023-10-05 johnstiles@google.com Factor out FuzzCreateValidInputsForRuntimeEffect to FuzzCommon.
2023-10-05 johnstiles@google.com Disable broken GMs on Adreno 5xx/6xx + Vulkan.
2023-10-05 kjlubick@google.com Split ToolUtils into a few files for easier modularization
2023-10-05 kjlubick@google.com Enforce IWYU on ToolUtils.h
2023-10-05 bungeman@google.com Revert "[pdf] Simplify filled paths"
2023-10-05 johnstiles@google.com Outset the rect passed to SkMesh::MakeIndexed.
2023-10-05 kjlubick@google.com Use buildifier to reformat all Bazel files
2023-10-05 robertphillips@google.com [graphite] Short circuit key generation for simple paints
2023-10-05 johnstiles@google.com Add saturate to list of supported WGSL intrinsics.
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 404a76d9bf0e to 46c5d45d5955 (1 revision)
2023-10-05 bungeman@google.com [pdf] Simplify filled paths
2023-10-05 kjlubick@google.com Make SkReadBuffer *not* call SkImages::DeferredFromEncodedData by default
2023-10-05 armansito@google.com [graphite][dawn][viewer] Support turning vsync off
2023-10-05 lovisolo@google.com [bazel] BazelBenchmarkRunner.cpp: Add more flags and better validation.
2023-10-05 robertphillips@google.com [graphite] Add CoeffBlenderBlock::AddBlock
2023-10-05 robertphillips@google.com [graphite] Add ColorSpaceTransformBlock::AddBlock
2023-10-05 johnstiles@google.com Enable child effects in SkMesh programs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
https://dart.googlesource.com/external/github.com/flutter/engine/+/356ab2a548623dd1d698d70261b543b1c97a3e4f
2 files changed
tree: 6496383e713dc4b034e0107d5840f1f57e554489
  1. ci/
  2. tools/
  3. .gitignore
  4. commits.json
  5. DEPS
  6. OWNERS
  7. README.md
README.md

Monorepo

A gclient solution for checking out Dart and Flutter source trees

Monorepo is:

  • Optimized for Tip-of-Tree testing: The Monorepo DEPS used to check out Dart and Flutter dependencies comes from the Flutter engine DEPS with updated dependencies from Dart.

Checking out Monorepo

With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:

mkdir monorepo
cd monorepo
gclient config --unmanaged https://dart.googlesource.com/monorepo
gclient sync -D

This gives you a checkout in the monorepo directory that contains:

monorepo/
  DEPS - the DEPS used for this gclient checkout
  commits.json - the pinned commits for Dart, flutter/engine,
                 and flutter/flutter
  tools/ - scripts used to create monorepo DEPS
engine/src/ - the flutter/buildroot repo
    flutter/ - the flutter/engine repo
    out/ - the build directory, where Flutter engine builds are created
    third_party/ - Flutter dependencies checked out by DEPS
      dart/ - the Dart SDK checkout.
        third_party - Dart dependencies, also used by Flutter
flutter/ - the flutter/flutter repo

Building Flutter engine

Flutter's instructions for building the engine are at Compiling the engine

They can be followed closely, with a few changes:

  • Googlers working on Dart do not need to switch to Fuchsia's Goma RBE, except for Windows. The GOMA_DIR enviroment variable can just point to the .cipd_bin directory in a depot_tools installation, and just goma_ctl ensure_start is sufficient.
  • The --no-prebuilt-dart-sdk option has to be added to every gn command, so that the build is set up to build and use a local Dart SDK.
  • The --full-dart-sdk option must be added to gn for the host build target if you will be building web or desktop apps.

Example build commands that work on linux:

MONOREPO_PATH=$PWD
if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then
  PATH=$MONOREPO_PATH/flutter/bin:$PATH
fi

export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin
goma_ctl ensure_start

pushd engine/src
flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk
autoninja -C out/host_debug_unopt
popd

Building Flutter apps

The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.

For example, to build and run the Flutter spinning square sample on the web platform,

MONOREPO_PATH=$PWD
cd flutter/examples/layers
flutter --local-engine=host_debug_unopt \
  -d chrome run widgets/spinning_square.dart
cd $MONOREPO_PATH

To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command

flutter create --platforms=windows,macos,linux

on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter

Testing

Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:

MONOREPO_PATH=$PWD
cd flutter/packages/flutter
flutter test --local-engine=host_debug_unopt
cd $MONOREPO_PATH

Troubleshooting

Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.

We will update this documentation to address them.

  • flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.

Windows

  • On Windows, gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.