Reland "[vm] Replace array GetIndexed graph intrinsics with flow graph builder implementation" This is a reland of commit d24b5d1f5eebffa8b20eddbdf5a9607aefeef5ab On top of the original change, the following is fixed and improved: 1) Flow graph builder (FGB) body is now also applied to dynamic invocation forwarders (similarly to graph intrinsics). 2) Frame can be omitted for functions which have a call on a shared slow path. This is needed to make FGB implementation of GetIndexed frameless, as it has GenericCheckBound which calls on shared slow path. (Graph intrinsics are frameless). 3) Range analysis is enabled for force-optimized functions, so more efficient code can be generated for boxing instructions. Range analysis is fixed to avoid crashes and correctly intersect ranges with constant boundaries (needed for some force-optimized FFI functions). 4) EliminateStackOverflowChecks pass is enabled for force-optimized functions so CheckStackOverflow can be eliminated. Original change's description: > [vm] Replace array GetIndexed graph intrinsics with flow graph builder implementation > > _Array, _GrowableList, internal and external typed data 'operator []' > are now implemented in the flow graph builder. > > Unlike graph intrinsics, flow graph created in the flow graph builder > can be used by the inliner. Corresponding graph intrinsics and native > methods are removed. > > Also, this change adds missing external typed data indexing operations. > > TEST=ci > > Change-Id: Ic19784481feadf54c096a587413e67b4e18353dc > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359940 > Reviewed-by: Ryan Macnak <rmacnak@google.com> > Commit-Queue: Alexander Markov <alexmarkov@google.com> TEST=ci Change-Id: I04ef008a04238d432683d7543cd047e35bad17c3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360560 Reviewed-by: Tess Strickland <sstrickl@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> https://dart.googlesource.com/sdk/+/0af6dde79d17f5b3cbafbdb997af00679caf0ba3
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.