Fine. Integrate string table support into binary I/O
Fine-grained manifests previously wrote strings as raw UTF-8, which
increased bytes on the wire and added CPU overhead. This change
integrates string tables into the core BinaryWriter/BinaryReader so
manifests (and other formats) can use string references instead of
duplicated UTF-8 payloads.
What changed
- BinaryWriter
- Add a shared StringIndexer and expose:
- writeStringReference / writeStringList /
writeOptionalStringReference
- writeStringTableAtEnd() to emit the table and a trailing u32
offset.
- Add clone() that shares the StringIndexer with child writers for
lazy/layered sections.
- BinaryReader
- Add initializeStringTableAtOffset(offset) (rename from
createStringTable).
- Add initializeStringTableFromEnd(), the counterpart to
writeStringTableAtEnd(), which reads the trailing u32 to find the
table.
- Bundle writer/reader
- Switch to writer string-table APIs and use
initializeStringTableAtOffset() when reading.
- ResolutionSink now extends BinaryWriter (removes the custom
_SummaryDataWriter) and AstBinaryWriter delegates string writes to
the sink.
- Replace ad-hoc “_writeStringReference/_writeStringList” helpers
with BinaryWriter methods; move small helpers to extensions.
- Data format
- Bump AnalysisDriver.DATA_VERSION to 560 to invalidate old caches.
Why
- Reduces duplicate string storage across manifests and resolution
chunks.
- Lowers serialization cost by replacing repeated UTF-8 blobs with
compact integer references.
- Unifies string handling across summaries and manifests, simplifying
future readers/writers.
Trade-offs
- Writers must finalize output correctly (emit the table before
takeBytes when using the “table at end” mode); misuse will break the
format.
- Sharing one StringIndexer across cloned writers slightly increases
table size when many unique strings are produced, but the dedup win
typically dominates.
Compatibility
- Existing bundle format continues to store four trailing u32 offsets
(base/resolved/libraries/references/stringTable). The new “table at
end” read path is added for formats that adopt it; bundle reading
remains compatible by using the explicit offsets.
Change-Id: I3648a59eeb6af453f2744415c13f864e9b49a167
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450972
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
https://dart.googlesource.com/sdk/+/eb938ee4bbca62b27e13859d17b8c0f29c12c9bd
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.