| commit | 935b9deb91164a2cb35806a4ad9336461702d6fe | [log] [tgz] |
|---|---|---|
| author | Ömer Sinan Ağacan <omersa@google.com> | Tue Feb 18 02:40:17 2025 -0800 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Tue Feb 18 02:42:20 2025 -0800 |
| tree | f8ce286ea11266e67bb66427003d7f1c4c22a7ee | |
| parent | 89340af6868a75fd3f2ed9a99aa40092fac97479 [diff] |
[dart2wasm] Don't compile catch blocks multiple times for JS exceptions Currently when a Dart `catch` block can catch both Dart and JS exceptions, we compile the `catch` body once in a Wasm `catch` block, once in a Wasm `catch_all` block. This is because a Dart exception needs to be caught in a `catch` with the right tag, to be able to get the exception and stack trace values, and JS exceptions need to be caught in `catch_all` and they come without error values and stack traces. With this CL we generate one Wasm block per Dart `catch` block. Wasm `catch` and `catch_all` blocks only do type tests and jump to the right Wasm `block` when a type test passes. This allows using the same block for multiple Wasm `catch` and `catch_all` blocks. When jumping to the block for a Dart `catch` we pass the error value and stack trace to the block. As before, when the caught exception is a JS exception, we pass an empty `JavaScriptError` as the error value and the call stack of the Dart `catch` as the stack trace. We also replace Wasm `rethrow` instruction with `throw` when compiling Dart `rethrow` statements. This change is necessary as the blocks for Dart `catch` blocks are no longer enclosed by a Wasm `try`, and it also makes it easier to switch to the new exception handling proposal, which doesn't have a `rethrow` instruction. This changes Wasm exceptions reported to the console in uncaught exceptions, but when we switch to the new exception handling instructions we will recover the stack traces, as `throw_ref` doesn't update the stack trace of the error value. Change-Id: I732c0192af158611d5f0a584182a48b0e13ff83a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/410321 Commit-Queue: Ömer Ağacan <omersa@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> https://dart.googlesource.com/sdk/+/5da354f46ebeb8683fc2deab5bfe8109baa2b433
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.