| commit | 918b638db4e58a2ebe78014b75aee3cb652d1f4b | [log] [tgz] |
|---|---|---|
| author | Alexander Markov <alexmarkov@google.com> | Wed Jan 15 08:13:52 2025 -0800 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Fri Jan 17 11:03:44 2025 -0800 |
| tree | 89dc69d28356cde28fc46d975f73dcea063c4d4c | |
| parent | c86cac1ebe64b47b12fa2d26de7e067e54ee29e9 [diff] |
[vm,dynamic_modules] Support members which are overridden implictly (transitively) by a dynamic module Consider the following situation: member M1 is overridden by another member M2; M2 is overridden in a dynamic module. Members which can be overridden in a dynamic module (such as M2) should be specified as 'can-be-overridden' in the dynamic interface. Members which are overridden implicitly/transitively (such as M1) are not required to be mentioned in the dynamic interface. However, when determining possible targets for a call with interface target M1, compiler should treat it as potentially overridden in a dynamic module. This change adds such handling to the VM/AOT. Dynamic interface annotator now marks members such as M1 with 'dyn-module:can-be-overridden-implicitly' pragma, and VM/AOT takes both can-be-overridden and can-be-overridden-implicitly into account. This change also simplifies handling of implicitly extenable classes in the VM/AOT - now VM handles both extendable and implicitly-extendable pragmas (from dynamic interface annotator) instead of recalculating implicitly extendable classes on its own. TEST=pkg/vm/test/transformations/dynamic_interface_annotator_test.dart TEST=dynamic_modules_suite/implicitly_extendable Fixes https://github.com/dart-lang/sdk/issues/59880 Change-Id: Id4570cc86303f8e45a061d696e9bca0d0b2b4b81 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403951 Reviewed-by: Slava Egorov <vegorov@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com> Reviewed-by: Nate Biggs <natebiggs@google.com> https://dart.googlesource.com/sdk/+/9e8e8e5fcad47058d9740c38dfbb69a1148cf8d5
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.