| commit | 90d6e49e660eed19ba1998a394f1a327742ee193 | [log] [tgz] |
|---|---|---|
| author | William Hesse <whesse@google.com> | Thu Apr 18 22:33:17 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Thu Apr 18 15:35:18 2024 -0700 |
| tree | 3f391bd3245c4303ece507e93123e01ab587d64b | |
| parent | e70151d2f13180c4b3b3262529580f9fdccd912e [diff] |
Revert "Bump web_socket_channel to b612fc2caa9f4c3c8947b4ffbb274bce33c54a04" This reverts commit 4d6919aa5e847b1a738d9b7b4d80885cc2a2ae09. Reason for revert: This adds additional transitive dependencies to the web_socket_channel package, which must be added to Flutter engine packages before landing. Please run the flutter-linux-try bot before rolling internal packages. See failure on https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-linux-host_debug/7089/overview Original change's description: > Bump web_socket_channel to b612fc2caa9f4c3c8947b4ffbb274bce33c54a04 > > Changes: > ``` > > git log --format="%C(auto) %h %s" ced3a37..b612fc2 > https://dart.googlesource.com/web_socket_channel.git/+/b612fc2 Avoid importing io_web_socket namespace (343) > https://dart.googlesource.com/web_socket_channel.git/+/ce69d31 Rename WebSocketAdapterWebSocketChannel to AdapterWebSocketChannel (344) > https://dart.googlesource.com/web_socket_channel.git/+/429e7d9 Implement IOWebSocketChannel as a WebSocketAdapterWebSocket subclass (342) > https://dart.googlesource.com/web_socket_channel.git/+/00cb13a Remove WebSocketChannel constructor (341) > https://dart.googlesource.com/web_socket_channel.git/+/1f3dfd7 Create an adapter for `package:web_socket` (339) > > ``` > > Diff: https://dart.googlesource.com/web_socket_channel.git/+/ced3a37193f89d5ee95792f342eeb15d3d55d8c1..b612fc2caa9f4c3c8947b4ffbb274bce33c54a04/ > Change-Id: I558a25a5f8cbe0704e40b7e60886c8934f04d2e8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362662 > Reviewed-by: Nate Bosch <nbosch@google.com> Change-Id: I91c1935a68570d18385207d0de4000213143c4ca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363660 Auto-Submit: William Hesse <whesse@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> https://dart.googlesource.com/sdk/+/2a265c183d62c10e9adbaa040dd85c420209cb9f
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.