| commit | 8ea652b0de9212c5504da0cf77e8e205d67731c6 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Wed Oct 25 11:09:38 2023 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Oct 25 04:11:40 2023 -0700 |
| tree | d427cffd85051305e941c715c616f0b9d6546cc1 | |
| parent | 98cdee9fc52aa48c20e0fadcc2bca40ac0200f51 [diff] |
[test_runner] First batch test after compiler launch gets more timeout The first test being compiled on a batch compiler pays for the cost of the batch compiler startup, meaning it is more likely to time out, e.g. see https://github.com/dart-lang/sdk/issues/53672. E.g via `tools/test.py '--progress=status' --report --time --write-results --write-logs --clean-exit -ncfe-strong-linux service/next_...` I get output like this: ``` 0:00:37.713771 - fasta - fasta-none release_x64/service/next_through_simple_linear_test/service 0:00:37.682524 - fasta - fasta-none release_x64/service/next_through_for_loop_with_break_and_continue_test/dds 0:00:36.805734 - fasta - fasta-none release_x64/service/next_through_create_list_and_map_test/service 0:00:36.589329 - fasta - fasta-none release_x64/service/next_through_simple_linear_2_test/dds 0:00:36.586428 - fasta - fasta-none release_x64/service/next_through_simple_linear_2_test/service 0:00:36.518832 - fasta - fasta-none release_x64/service/next_through_for_each_loop_test/dds 0:00:36.407107 - fasta - fasta-none release_x64/service/next_through_create_list_and_map_test/dds 0:00:36.259945 - fasta - fasta-none release_x64/service/next_through_for_each_loop_test/service 0:00:36.211573 - fasta - fasta-none release_x64/service/next_through_call_on_field_in_class_test/service 0:00:36.189456 - fasta - fasta-none release_x64/service/next_through_call_on_field_in_class_test/dds 0:00:35.974007 - fasta - fasta-none release_x64/service/next_through_for_loop_with_break_and_continue_test/service 0:00:35.921138 - fasta - fasta-none release_x64/service/next_through_simple_linear_test/dds 0:00:09.690812 - fasta - fasta-none release_x64/service/next_through_multi_catch_test/service 0:00:09.562068 - fasta - fasta-none release_x64/service/async_next_test/service 0:00:09.530882 - fasta - fasta-none release_x64/service/next_through_operator_bracket_test/dds 0:00:09.407169 - fasta - fasta-none release_x64/service/next_through_function_expression_test/dds 0:00:09.366673 - fasta - fasta-none release_x64/service/next_through_multi_catch_test/dds 0:00:09.327895 - fasta - fasta-none release_x64/service/next_through_function_expression_test/service 0:00:09.303926 - fasta - fasta-none release_x64/service/next_through_await_for_test/service 0:00:09.236295 - fasta - fasta-none release_x64/service/next_through_simple_async_with_returns_test/dds ``` where the first 12 (the really slow ones) each is the first test being run on that particular batch compiler, where they both pay for the startup cost of the batch compiler (~12 seconds on my machine when launching 12 simultaneously which is the default on my machine -- it's probably more on the bots) and for the jit not having warmed up yet: E.g. the first test compiles in ~22 seconds, the second in ~9 seconds, the third in ~6 seconds on my machine (again with 12 simultaneous runs). To make it less likely that the first compile times out this CL adds some extra time allowance for the first run after the bulk compiler is started. For now it's 30 seconds, but it can be adjusted if needed. Longer term we should probably start a batch compilation test by aot-compilng the batch compiler (which, at least currently, doesn't support asserts (https://github.com/dart-lang/sdk/issues/53343) which is unfortunate). I'll leave that for a future CL. Bug: https://github.com/dart-lang/sdk/issues/53672 Change-Id: Id3427223c46c1e7a34b401097a3f7d5f1321ad93 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332220 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: William Hesse <whesse@google.com> https://dart.googlesource.com/sdk/+/cfd04d3b5115c21a0979e9d932db4e319b7fc8df
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.