Shared analysis: API changes for pattern variables. This change is part of a process of shifting the responsibility of tracking the set of variables defined by a pattern into the shared analysis logic. A `variableName` parameter is added to `analyzeDeclaredVariablePattern`, and a field `componentVariables` is added to `MatchContext` to track the set of variables associated with each variable name in a pattern. In the CLs that follow, I plan to use this information in the place of the `getJoinedVariableComponents` method. This will give the client more flexibility in deciding when and how to join variables in logical-or patterns. (This is needed because the CFE joins variables eagerly as a necessary part of lowering, whereas the analyzer joins variables only at the end of the pattern, to improve the quality of error messages). Also, a `variables` parameter is added to `analyzeIfCaseElement` (to make it consistent with `analyzeIfCaseStatement`), and the `patternVariables` parameter is removed from `analyzePatternForIn`. With these changes, we now consistently have a `variables` map in situations where the pattern match is refutable (and thus logical-or patterns are allowed), and we have no `variables` map in situations where the pattern match is irrefutable (and thus no variable joining is needed). Change-Id: I1c511d12e827c52ef9bd8b7ff2b561ea9713a932 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279239 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/c498870e85715c1d7da276d1f08157168885c010
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.