| commit | 8b5b585bd5e20442d59c5b9b8c828b5cb130721a | [log] [tgz] |
|---|---|---|
| author | Tess Strickland <sstrickl@google.com> | Wed Dec 04 14:36:46 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Dec 04 09:30:59 2024 -0800 |
| tree | 1d255433b335ffcf9b6a7343f28810d494031c0d | |
| parent | 025d82254a994b8214d2991d32ee465503b4b187 [diff] |
Reland "[vm] Enforce that entry points must be annotated by default." This is a reland of commit cb9ecbc3636aaa4e8c8301caa4bab2d903825bf3 This reland only turns on the entry point verification flag by default in AOT mode. After Flutter tests that use native access in JIT mode have been appropriately updated, a followup CL will turn this flag on by default in JIT mode as well. Original change's description: > [vm] Enforce that entry points must be annotated by default. > > Changes the default value of the --verify-entry-points flag > to true. > > Changes the default value for the check_is_entrypoint argument to > to the Invoke/InvokeGetter/InvokeSetter flags to true. The mirrors > library implementation and calls via vm-service explicitly pass > false for this argument now. > > Add annotations as needed, such as annotating classes with > annotated generative constructors. In some cases, the annotations > were more general than needed (e.g., annotating with a no-argument > entry point annotation when only the setter is needed), so make > those annotations more specific. > > As this pattern is already common in downstream code, allow > Dart_Invoke on fields as long as the field is annotated for getter > access. (That is, calling Dart_Invoke for a field is equivalent to > retrieving the closure value via Dart_GetField and then calling > Dart_InvokeClosure.) > > TEST=vm/cc/DartAPI_MissingEntryPoints > vm/dart/entrypoints_verification_test > > Issue: https://github.com/dart-lang/sdk/issues/50649 > Issue: https://github.com/flutter/flutter/issues/118608 > > Change-Id: Ibb3bf15632ab2958d8791b449af8651d47f871a5 > Cq-Include-Trybots: luci.dart.try:vm-aot-linux-product-x64-try,vm-aot-linux-debug-x64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-product-arm64-try,vm-aot-dwarf-linux-product-x64-try > CoreLibraryReviewExempt: adding/editing vm-only pragma annotations > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363566 > Reviewed-by: Martin Kustermann <kustermann@google.com> > Commit-Queue: Tess Strickland <sstrickl@google.com> TEST=vm/cc/DartAPI_MissingEntryPoints vm/dart/entrypoints_verification_test Change-Id: I24919c32ab4760c7c5435c378879791086256f02 Cq-Include-Trybots: luci.dart.try:vm-aot-linux-product-x64-try,vm-aot-linux-debug-x64-try,vm-aot-mac-release-arm64-try,vm-aot-mac-product-arm64-try,vm-aot-dwarf-linux-product-x64-try,flutter-linux-try,vm-linux-debug-x64-try,vm-linux-release-x64-try,vm-appjit-linux-product-x64-try CoreLibraryReviewExempt: adding/editing vm-only pragma annotations Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391620 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Tess Strickland <sstrickl@google.com> https://dart.googlesource.com/sdk/+/9b06e26620a081c89931e5618336ff23dc6083be
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.