Fixes the handling of linked edit groups in ChangeBuilder NOTE: Amost all of this code was written by AI, but has all been reviewed by me. I did a tiny amount of cleanup that was faster to do myself than to ask the agent to do it. That doesn't mean that I've caught all of the AI's bugs, but I did try to ensure that test coverage was complete enough to also catch problems. This fixes a bug in the way the `ChangeBuilder` handled linked edit groups. The bug resulted from the fact that the offsets of the linked edit groups was adjusted at the time each edit location was added. Doing that meant that they weren't re-adjusted when new non-group edits were added at a lower offset, making it possible for the edits to have the wrong offsets when they were sent to the client. The solution is to not adjust them when they are created, but to adjust them during `finalize` when other offsets are adjusted. At that point we have full knowledge of all of the edits so we can get it right. Doing that required adding a reference to the each edit in the file edit builder (because only the edits in the same file can require that an adjustment be made). My hope is that with this change in place I can complete the arc of work to update all of our refactors to use the `ChangeBuilder` APIs to build the edits. Change-Id: I59ddb0dee1f9dbb15bdcc38a84ddc07acefe6262 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/507622 Reviewed-by: Samuel Rawlins <srawlins@google.com> https://dart.googlesource.com/sdk/+/4af407d11eeaadc89f4454955805d01744d520ac
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.