| commit | 80aed13e89486779d4953565478ba229fa0703ab | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Wed Sep 25 12:23:01 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Sep 25 05:25:13 2024 -0700 |
| tree | f4706f3c03c0ad38cb1cf33e07202e7b79813178 | |
| parent | ba0129466698d00c1d72916f27be749315243486 [diff] |
Implement matchInferableParameter in MiniAstOperations. Previously the implementation of this method was a stub. It turns out that all the necessary infrastructure was in place already, however the type arguments supplied by MiniAstOperations to TypeAnalyzerOperationsMixin and TypeAnalyzerOperations needed to be changed: in the "mini_ast" representation of types, an InferableParameter is represented by a String, not a PromotedTypeVariableType. This is because InferableParameter is meant to represent the declaration of the type parameter (StructuralParameter for the CFE, TypeParameterElement for the analyzer), not the type itself. The types used for unit testing in _fe_analyzer_shared don't have a separate notion of the declaration of a type parameter, so we just use its name. Implementing this logic required adding a method `TypeSystem.matchTypeParameterType`, which checks if a Type is a type parameter type, and returns the name of the type parameter if so. I based this on the previously existing `TypeSystem._isTypeVar` method (which performed the same job but did not return the type parameter name). I also took the liberty of fixing a flow analysis test that treated `T` as a type variable but failed to mark it as a type variable by calling `addTypeVariable`. This should help pave the way for unit testing more of the shared infrastructure for types. Change-Id: Ia7a9777ec3d90a5886567dcb9f831e388e372f32 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/386607 Reviewed-by: Chloe Stefantsova <cstefantsova@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/13d4eaf99a5083daffc6b635a6ca2f0000077785
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.