| commit | 7eac30dfe2483a71bd67ee7f289d390aae1a2b09 | [log] [tgz] |
|---|---|---|
| author | Matan Lurey <matanlurey@users.noreply.github.com> | Mon Jan 27 19:43:46 2025 -0800 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Jan 27 20:26:26 2025 -0800 |
| tree | 801b998e466be771e9f82ab416539619fd4aa85f | |
| parent | df8746bdf5347b7f7b8bc4f48996ec0dc1edb51b [diff] |
Remove `scenario_app/android` and rename to `ios_scenario_app`. (#160992) 🚫 **BLOCKED** : Do not merge until https://github.com/flutter/flutter/issues/161261 (additional test coverage). --- This PR eliminates (1) `scenario_app/android`, and all references to an Android `scenario_app`, including documentation, CI configuration, build rules, test runner, Android-side test application, and (2), to verify and disambiguate the remains, renames the folder `ios_scenario_app`, which is now accurate. It also eliminates elements that were _only_ used in the Android-side scenario_app, such as Firebase Test Lab uploading. I would be open to doing this in phases if we thought it was better to do so, but given its mostly a mechanical change (and by renaming the directory, references can be checked merely by looking for `/\bscenario_app/`, I believe this is safe to iterate on and eventually merge after the holidays. ## Background As of the merged mono-repo, there is no longer a requirement for the engine to be testable as a standalone unit. As an example, [`%ENGINE%/testing/scenario_app`](https://github.com/flutter/flutter/tree/3762f2e9731ce97808fb2d78805f6712be83654d/engine/src/flutter/testing/scenario_app), which was intended to _emulate_ the Flutter framework (and some of `flutter_tools` tooling), load the iOS and Android embedder, and run various "scenarios" (which ran a combination of `dart:ui` code and Android Java/iOS Obj-C) verifying golden-file screenshots. Instead, it is now possible to write and run _real_ (full) Flutter apps the same way that an end-user (or our own tests) would. One such example is [`dev/native_driver_test`](https://github.com/flutter/flutter/tree/master/dev/integration_tests/native_driver_test), which is a full-fledged Flutter app, which uses standard tooling (i.e. `flutter`), to test most of the same elements that previously were only tested in the Android version of `scenario_app`. https://dart.googlesource.com/external/github.com/flutter/flutter/+/9e273d5e6e2e75336f26951a09aba0f5656a7e77
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.