Roll Skia from 8c936fb9ba8e to 32f4cfc2460b (27 revisions) (#41891)

https://skia.googlesource.com/skia.git/+log/8c936fb9ba8e..32f4cfc2460b

2023-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c441206103b1 to b0f9c01ec303 (6 revisions)
2023-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c4d18f21ffde to 48f97fe0593e
2023-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 07d94082da0b to d36b7c91621a (7 revisions)
2023-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0d5474fe31ef to c4d18f21ffde (7 revisions)
2023-05-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 9ebfb6b54814 to a62e8dbc3467 (1 revision)
2023-05-09 vmiura@google.com SkStrikeCache: Optimize purging of pinned strikes
2023-05-09 jvanverth@google.com [Direct3D] Check for null mapped pointer in onReadPixels
2023-05-09 brianosman@google.com Remove temporary analytic AA APIs
2023-05-09 scroggo@google.com Reland "Add support for decoding CICPs in Android"
2023-05-09 robertphillips@google.com [graphite] Disable MakeColorSpace_Test in Dawn
2023-05-09 weiyuhuang@google.com fix incorrect check
2023-05-09 johnstiles@google.com Switch to SkNoDestructor<T> instead of allocations.
2023-05-09 kjlubick@google.com Organize fontations Bazel rules to allow stub impls
2023-05-09 jvanverth@google.com [graphite] Add VulkanImageView class.
2023-05-09 brianosman@google.com Force AAA in the canvaskit GMs build script
2023-05-09 jamesgk@google.com [graphite] Account for shader blend mode correctly in precomp
2023-05-09 johnstiles@google.com Remove DSL-based intrinsic functions.
2023-05-09 johnstiles@google.com Remove DSL usage from FunctionCall.
2023-05-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 180f3708bf26 to 07d94082da0b (10 revisions)
2023-05-09 lokokung@google.com Update deprecated ShaderModuleWGSLDescriptor.source to .code instead.
2023-05-09 fmalita@chromium.org Add some mesh (drawVertices) samples
2023-05-09 lovisolo@google.com [bazel] //tests/BUILD.bazel: Extract test groups into //tests/testgroups.bzl.
2023-05-09 johnstiles@google.com Reland "Add SkNoDestructor<T> class to Skia."
2023-05-09 johnstiles@google.com Remove DSL usage from RTAdjust fixup code.
2023-05-09 jvanverth@google.com Update Skia Vulkan headers to 1.2.197
2023-05-09 djsollen@google.com Revert "Add support for decoding CICPs in Android"
2023-05-09 brianosman@google.com Revert "Add SkNoDestructor<T> class to Skia."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://dart.googlesource.com/external/github.com/flutter/engine/+/4db1fa40d7b711522b3184a079ba63dec00bf3a2
2 files changed
tree: dcba6c5eab31891b16e203fae595f5d290c4c770
  1. ci/
  2. tools/
  3. .gitignore
  4. commits.json
  5. DEPS
  6. OWNERS
  7. README.md
README.md

Monorepo

A gclient solution for checking out Dart and Flutter source trees

Monorepo is:

  • Optimized for Tip-of-Tree testing: The Monorepo DEPS used to check out Dart and Flutter dependencies comes from the Flutter engine DEPS with updated dependencies from Dart.

Checking out Monorepo

With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:

mkdir monorepo
cd monorepo
gclient config --unmanaged https://dart.googlesource.com/monorepo
gclient sync -D

This gives you a checkout in the monorepo directory that contains:

monorepo/
  DEPS - the DEPS used for this gclient checkout
  commits.json - the pinned commits for Dart, flutter/engine,
                 and flutter/flutter
  tools/ - scripts used to create monorepo DEPS
engine/src/ - the flutter/buildroot repo
    flutter/ - the flutter/engine repo
    out/ - the build directory, where Flutter engine builds are created
    third_party/ - Flutter dependencies checked out by DEPS
      dart/ - the Dart SDK checkout.
        third_party - Dart dependencies, also used by Flutter
flutter/ - the flutter/flutter repo

Building Flutter engine

Flutter's instructions for building the engine are at Compiling the engine

They can be followed closely, with a few changes:

  • Googlers working on Dart do not need to switch to Fuchsia's Goma RBE, except for Windows. The GOMA_DIR enviroment variable can just point to the .cipd_bin directory in a depot_tools installation, and just goma_ctl ensure_start is sufficient.
  • The --no-prebuilt-dart-sdk option has to be added to every gn command, so that the build is set up to build and use a local Dart SDK.
  • The --full-dart-sdk option must be added to gn for the host build target if you will be building web or desktop apps.

Example build commands that work on linux:

MONOREPO_PATH=$PWD
if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then
  PATH=$MONOREPO_PATH/flutter/bin:$PATH
fi

export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin
goma_ctl ensure_start

pushd engine/src
flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk
autoninja -C out/host_debug_unopt
popd

Building Flutter apps

The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.

For example, to build and run the Flutter spinning square sample on the web platform,

MONOREPO_PATH=$PWD
cd flutter/examples/layers
flutter --local-engine=host_debug_unopt \
  -d chrome run widgets/spinning_square.dart
cd $MONOREPO_PATH

To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command

flutter create --platforms=windows,macos,linux

on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter

Testing

Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:

MONOREPO_PATH=$PWD
cd flutter/packages/flutter
flutter test --local-engine=host_debug_unopt
cd $MONOREPO_PATH

Troubleshooting

Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.

We will update this documentation to address them.

  • flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.

Windows

  • On Windows, gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.