| commit | 7ce98bf7fbafca066d0995261ee8af4904459136 | [log] [tgz] |
|---|---|---|
| author | Paul Berry <paulberry@google.com> | Wed Nov 20 19:32:09 2024 +0000 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Wed Nov 20 11:33:57 2024 -0800 |
| tree | 61dc059d4aa108c8810f35f9f148c0cd2347b08c | |
| parent | 294fa3c61dd97b4ee9e0c51277f3506687aec767 [diff] |
[analyzer] Represent `FutureOr<...>` as `FutureOrTypeImpl`. This change introduces the class `FutureOrTypeImpl` to represent the special types of the form `FutureOr<...>`, which were previously represented as ordinary instances of `InterfaceType`. This class mirrors the CFE's `FutureOrType` class. Adding it will facilitate further code sharing between the analyzer and the CFE, because it will allow code that's shared between the analyzer and CFE to use `is` tests to recognize `FutureOr` types. In a follow-up CL I intend to add a base class that is common to analyzer and CFE `FutureOrType` representations. Note that in https://dart-review.googlesource.com/c/sdk/+/396320, when I introduced the `NullTypeImpl` class, I took pains to find all the places in the analyzer that might call the `InterfaceTypeImpl` constructor, and updated them so that if the type they are creating is the `Null` type, they call the `NullTypeImpl` constructor instead. That was tractable for the type `Null`, since there's basically just a single `Null` type corresponding to a single declaration in `dart:core`. At first I tried doing a similar thing for `FutureOr`, but it proved to be a big pain, because `FutureOr` types get created all over the place. It was difficult to be confident that I'd updated all the necessary call sites. So instead I've put the necessary logic in the `InterfaceTypeImpl` constructor itself (by changing it into a factory constructor). This is a much lower risk approach and I'm much happier with it. In a follow-up CL I'll change the logic for `NullTypeImpl` to follow the same factory approach. Change-Id: I54c6998f991456199076faeac995e433cc88845d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396523 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Paul Berry <paulberry@google.com> https://dart.googlesource.com/sdk/+/237bb3bb2f592d6f4d46ffd27a0b3ed42b956b99
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.