)]}'
{
  "commit": "6ffcee6f97ffff43a80f2162ce95c83660c18d22",
  "tree": "8795f71f81ac929868106e95ea427cb039a4a48f",
  "parents": [
    "376e2f24380c306b35dba81fc12b016195c671fa"
  ],
  "author": {
    "name": "Daco Harkes",
    "email": "dacoharkes@google.com",
    "time": "Mon Dec 12 15:46:33 2022 +0000"
  },
  "committer": {
    "name": "dart-internal-monorepo",
    "email": "dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com",
    "time": "Mon Dec 12 07:49:28 2022 -0800"
  },
  "message": "[vm/ffi] Fix FfiTrampolineData GC bug\n\nThis lets the GC visit FfiTrampolineData::c_signature again.\n\nhttps://dart-review.googlesource.com/c/sdk/+/272201 stopped adding\nFfiTrampolineData::c_signature to snapshots. However, instead of\nskipping it manually in app_shapshot.cc, we skipped it in\nraw_object.h, which also caused the GC to skip it.\nThis CL adds it back in as we need it in JIT snapshots. This way we\nkeep it consistent between AOT/JIT snapshots.\n\nTEST\u003dtests/ffi/regress_b_261224444_test.dart\n\nThe c signatures of FFI trampolines were not properly traced in the\nprecompiler, causing us to hit an assert when the classes mentioned in\nthose types where only referenced from a signature and not retained\nfor any other reason.\n\nTEST\u003dtests/ffi/native_assets/process_test.dart (dartkp)\n\nCloses: https://github.com/dart-lang/sdk/issues/50678\nBug: b/261224444\nChange-Id: I84fc880744c2045ea3e2ef4f37df454b80b2faeb\nCq-Include-Trybots: luci.dart.try:vm-precomp-ffi-qemu-linux-release-arm-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-kernel-reload-rollback-linux-debug-x64-try,vm-kernel-reload-linux-debug-x64-try,app-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-linux-debug-x64-try\nReviewed-on: https://dart-review.googlesource.com/c/sdk/+/274387\nReviewed-by: Martin Kustermann \u003ckustermann@google.com\u003e\nAuto-Submit: Daco Harkes \u003cdacoharkes@google.com\u003e\nCommit-Queue: Daco Harkes \u003cdacoharkes@google.com\u003e\n\nhttps://dart.googlesource.com/sdk/+/e3e355e16a8b67ba6a1d7a83f837e8e69cf71534\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5a83d1946bac2e8098e888e73dd9f58f37103c6e",
      "old_mode": 33188,
      "old_path": "DEPS",
      "new_id": "a9d54167d88c43ccaddf8efa13a20b55feca42c6",
      "new_mode": 33188,
      "new_path": "DEPS"
    },
    {
      "type": "modify",
      "old_id": "c60056ee4d553f7d0bda44242e4d958b06782433",
      "old_mode": 33188,
      "old_path": "commits.json",
      "new_id": "470246bb4ca0f91ef76008c547e2a1ece898afcd",
      "new_mode": 33188,
      "new_path": "commits.json"
    }
  ]
}