Add `UNREACHABLE_SWITCH_DEFAULT` warning to the analyzer. This warning is similar to the existing `UNREACHABLE_SWITCH_CASE` warning, except that it warns if the `default` clause of a switch statement is unreachable due to all the `case` clasuses fully exhausting the switched type. To make the implementation easier, I changed the API for the `reportExhaustiveness` method in `_fe_analyzer_shared` (which is the primary entry point to the shared exhaustiveness checker). Previously, this method returned a list of `ExhaustivenessError`, where each list element was either an `UnreachableCaseError` (indicating that a certain case was unreachable) or a `NonExhaustiveError` (indicating that the entire switch statement was not exhaustive). If the caller passed in `false` for `computeUnreachable`, `UnreachableCaseError`s would not be returned, so the returned list would either be empty or contain a single `NonExhaustiveError`. The new API renames the types for clarity: - `NonExhaustiveError` becomes `NonExhaustiveness`, to highlight the fact that it's not necessarily an error for the switch's cases to be non-exhaustive; it's only an error if the scrutinee's static type is an "always exhaustive" type and there is no `default` clause. - `UnreachableCaseError` becomes `CaseUnreachability`, to highlight the fact that it's not an error for a case to be unreachable; it's a warning. Also, the new API adds instances of `CaseUnreachability` to an optional user-provided list instead of returning a newly created list; this allows callers to communicate that they don't need to see `CaseUnreachability` information by passing `null`. This frees up the return type to simply be an instance of `NonExhaustiveness` (if the cases are not exhaustive) or `null` (if they are exhaustive). This makes it easier for the analyzer to decide whether to issue the new warning, because it doesn't have to dig around the list looking for an instance of `NonExhaustiveness`. The new warning has an associated quick fix (remove the unreachable `default` clause). This quick fix uses the same `RemoveDeadCode` logic in the analysis server that the existing `UNREACHABLE_SWITCH_CASE` warning uses. Fixes https://github.com/dart-lang/sdk/issues/54575. Bug: https://github.com/dart-lang/sdk/issues/54575 Change-Id: I18b6b7c5249d77d28ead7488b4aae4ea65c4b664 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/378960 Reviewed-by: Johnni Winther <johnniwinther@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Samuel Rawlins <srawlins@google.com> Reviewed-by: Erik Ernst <eernst@google.com> https://dart.googlesource.com/sdk/+/cda2815bb1f028b4d88f664670865968bc64f847
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.