Fine. Write URIs and lookup names as string refs in manifests
Switch serialization of heavily repeated strings (URIs, `LookupName`s,
and select identifiers) from inline UTF-8 blobs to string references
backed by a per-blob string table. Readers now initialize the table from
the end of the buffer, and writers emit it once at the end.
This cuts duplication in library/requirements/diagnostics bundles and
improves both size and speed when analyzing the analyzer:
- size: 112 MB → 62 MB (~45% smaller)
- time: 450 ms → 310 ms (~31% faster)
Key changes
- Use `writeStringReference` / `readStringReference` for:
- URIs (`writeUri`/`readUri`); parse via `uriCache.parse`.
- `LookupName`, `BaseName`, and various manifest/type strings
(e.g., token buffers, member/top-level names, record field names,
named parameter names).
- Add `writeStringTableAtEnd()` in all writers that produce persisted
blobs, and `initializeStringTableFromEnd()` in matching readers:
- `LinkedBundleProvider` (get/put paths)
- `LibraryDiagnosticsBundle` (toBytes/fromBytes)
- Manifest and requirements assert-serialization paths
- Bump `AnalysisDriver.DATA_VERSION` to 561 to invalidate old caches.
Why this works
- Manifests and requirements repeat the same URIs and names across many
entries. Interning them through a string table removes redundancy and
reduces I/O.
- `uriCache.parse` avoids repeated `Uri` allocations and speeds up
lookup.
Trade-offs
- Writers must call `writeStringTableAtEnd()` exactly once after all
payload writes and before `takeBytes()`.
- Readers that consume string references must initialize the table
before any reference reads.
Change-Id: I2346e02fa34e0f421b6f15ccd485a0d19b00062d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451126
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
https://dart.googlesource.com/sdk/+/17abf40e0f2c6f1b2d03774523726570a2dc8967
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.