Only set `isExplicitlyExhaustive` on switch statements without default clauses. This enables the front end to skip the old-style (enum-based) exhaustiveness checking algorithm when pattern support is enabled, because with pattern support enabled, switches on enums are required to be exhaustive (this will be checked by the new exhaustiveness checking algorithm). That in turn means that in the future, when we remove support for language versions that lack patterns support, we will be able to remove the old-style exhaustiveness checking algorithm. This change has a small effect on code generated by the WASM back-end (the only back-end that uses `isExplicitlyExhaustive`): for a switch statement that is exhaustive *and* has an unreachable `default` clause, after testing all the cases, the WASM back-end will generate a branch to the `default` case. Previously it would instead generate an `unreachable` instruction. There should be no behavioural difference because the instruction in question is unreachable in both cases. Also, there should be negligible code size difference because the body of the `default` case is being emitted either way. Bug: https://github.com/dart-lang/sdk/issues/50419 Change-Id: Id6bd7d9a540cb1b4d9c3624db8ff494438276bea Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274924 Reviewed-by: Aske Simon Christensen <askesc@google.com> Commit-Queue: Paul Berry <paulberry@google.com> Reviewed-by: Johnni Winther <johnniwinther@google.com> https://dart.googlesource.com/sdk/+/9b294b846b16543c9321cc77f8bb97ccfe763e7a
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.