| commit | 52c65b157c9bcd8e0bf735c810f71ea2577b5320 | [log] [tgz] |
|---|---|---|
| author | MarkZ <markzipan@google.com> | Mon Mar 17 10:34:48 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Mar 17 10:37:14 2025 -0700 |
| tree | 2cf6d66cd34a713a3039bcecba653d07ad840ae3 | |
| parent | 9e8337ece67fa5946bf630067f152df1b26d2d45 [diff] |
Reland "[ddc] Overhauling tearoff equality and identity." This new update adds fixes + tests for cross-module super mixins. Super getters can refer to mixins compiled in other modules, so we need to expose all mixin names to make them accessible from their enclosing library. This is a reland of commit e4c4d0f839ce4998a46ac3997aea2668d3edd48f Original change's description: > [ddc] Overhauling tearoff equality and identity. > > Hot reload requires DDC to update how its tearoffs are represented. Tearoffs obey the following conventions: > * Instance tearoffs are never identical > * Tearoffs with the same object target and name have the same hash code (even if they resolve to different functions across hot reloads) > * Two separate tearoffs of the same member are equal > > To support this, tearoff equality must not depend on the bound object and method but a composite of the bound object, torn off member name, and the exact class/object from which the member was torn off. > > Notable changes: > * Methods' immediately bound targets are emitted with member signatures. This is required to determine the bound targets for instance and dynamic tearoffs. Bound targets are identified by `libraryUri:class` strings. > * `applyMixin` passes in a 'true' bound target. This is because mixin applications' members are considered children of their 'on' class (not the mixed in class) wrt equality/hashCode. > * `bind` is modified to pass in its 'true' bound object to support mixins' super getters. > * `tearoff` and `staticTearoff` are modified to accept a bound target string (only required for static tearoffs, as they are bound at tearoff-creation-time). > * Static tearoffs avoid using their bound object for hashcode and equality, as these libraries may be wrapped in proxy objects. > * Tearoff equality and hashCode are updated to consider bound object, bound name, and its bound method's immediate target. > * 'noSuchMethod' and 'toString' methods are always accessed through their extension property during signature lookups. > > > Change-Id: Ica5501b6860c605db50aa945bafb6802a7317511 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406723 > Reviewed-by: Nate Biggs <natebiggs@google.com> > Reviewed-by: Nicholas Shahan <nshahan@google.com> > Commit-Queue: Mark Zhou <markzipan@google.com> Change-Id: I645992030f9106c158426412387ddecafc78e3f4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/415102 Reviewed-by: Nate Biggs <natebiggs@google.com> Commit-Queue: Mark Zhou <markzipan@google.com> Reviewed-by: Nicholas Shahan <nshahan@google.com> https://dart.googlesource.com/sdk/+/ba90daf304abb446be20816709adee709d7b1021
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.