| commit | 4ffbc4cedddfab2b100af3cf56e0465b2011b257 | [log] [tgz] |
|---|---|---|
| author | Ömer Ağacan <omersa@google.com> | Tue Apr 08 09:29:33 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Tue Apr 08 09:34:07 2025 -0700 |
| tree | d3b474a1e1c7dc3b86818d1cdf31f30824d70b76 | |
| parent | 72d9f73af047ffc4adb44be0caf2fa1abe7d5200 [diff] |
Reland "[dart2wasm] Don't dartify JS values when returning as void" This is a reland of commit 4bb05dc562c0d5f32436bf31d75d3f96f4677601 Initial commit didn't properly box the `void` return value, so when we cast the return value to `ref #Top` to pass it to a Dart function (as `Object?` or `dynamic`) it caused "illegal cast" traps. In this commit we properly box the `externref` as `JSValue` (a proper Dart class). A new test added passing the return value of a `void` JS return to `print`. Original change's description: > [dart2wasm] Don't dartify JS values when returning as void > > When calling a JS function that returns `void`, avoid dartifying the > result. > > Technically the return value of `void` functions can still be used, by > casting the return type to `Object?` or `dynamic`. However this > shouldn't be done, and `dartifyRaw` overhead just to support this case > which should be extremely rare is too much. > > Any hacky code that uses return values of `void`-returning JS interop > functions can manually dartify the retrun values with `toDart` or > similar. > > Issue: https://github.com/dart-lang/sdk/issues/60357 > Change-Id: Ic370c7cf6eb6982f61f8a07c91e3bb93c5345ac6 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417240 > Reviewed-by: Srujan Gaddam <srujzs@google.com> > Reviewed-by: Martin Kustermann <kustermann@google.com> > Commit-Queue: Ömer Ağacan <omersa@google.com> Change-Id: I264211cca4f6b87e63d68909647975ab96f0b5bd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421080 Commit-Queue: Ömer Ağacan <omersa@google.com> Reviewed-by: Srujan Gaddam <srujzs@google.com> https://dart.googlesource.com/sdk/+/b372b54ecb51e6877f0ba60499c13c5fb9bc2173
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.