| commit | 4aa2cb5be9f65b78a3381968fcd2e4f3d81c4de9 | [log] [tgz] |
|---|---|---|
| author | Konstantin Shcheglov <scheglov@google.com> | Mon Apr 07 11:39:28 2025 -0700 |
| committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Mon Apr 07 11:41:34 2025 -0700 |
| tree | a2a1fe0fb479e18a6a4a514c383e9726f6ce3877 | |
| parent | e2d09d7dc3e2c2b6477a4a00ab498bd66f525072 [diff] |
Fine. Fix memory leak in LibraryContext for no fine-grained dependencies. We want to keep the cache of linked bundles with associated fine-grained dependencies and library manifests, so that we don't have to deserialize them after every API affecting change to a file in transitive dependencies. In case of the analyzer/ incremental analysis it can makes analysis up to 2x faster. OTOH, it is not clear to me how to evict entries from this cache. Maybe when the driver switches to idle, so whatever we put aside when potentially invalidating libraries, and did not use when re-loading libraries, discard these? This still theoretically could lead to negative effect if the driver is continuously kept busy with work. But better then nothing. Without fine-grained dependencies we never tried to cache anything other than just bytes. If we need to re-load a library, we create `BundleReader` from bytes. But now, as the amount of other work becomes smaller, the overhead of reading this information from bytes becomes more visible. So, for now I just want to fix the bug for everyone, when fine-grained dependencies are not enabled. Change-Id: I822a89b37ce870bbdfbc474e6e140a3cf070cfdc Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420741 Reviewed-by: Paul Berry <paulberry@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> https://dart.googlesource.com/sdk/+/789ce47c0c18014a71c408f95c186fa08508e15f
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.