commit | 44e777e911112d701b6e835a8e226d6b83b22783 | [log] [tgz] |
---|---|---|
author | Ömer Ağacan <omersa@google.com> | Fri Apr 11 04:14:04 2025 -0700 |
committer | dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com> | Fri Apr 11 04:16:51 2025 -0700 |
tree | 56c67afee21b2ca58454c3f02478e084bb65cc79 | |
parent | 205b37f92db7d58ffe244f26220cae1dd8166d2f [diff] |
[dart2wasm] JS interop: pass small ints as i31ref In V8, the only way to pass a Wasm integer or float to JS without allocation is by passing it as a 31-bit integer. This can be done by: 1. Passing as `i32`. If the integer fits into 31 bits it's passed without allocation. 2. Passing as externalized `i31ref`. (1) requires importing the JS function with different signatures: for each `int` argument we would need a signature with the `i32` as the Wasm argument type, and another with `externref` (or `f64` if we want to pass large integers as `f64`). This is not feasible as with a JS function with N `int` arguments we would need `2^N` imports. So we implement (2): we import each interop function with one signature, passing `externref` as the argument, as before. When the number fits into 31 bits we convert it to an `i31ref` and externalize it. Otherwise we convert the number to `externref` as before, by calling the JS function `(o) => o` imported with type `[f64] -> [externref]`. New benchmark checks `int` passing for small (31 bit) and large (larger than 31 bit) integers. Results before: WasmJSInterop.call.void.1ArgsSmi(RunTimeRaw): 0.020 ns. WasmJSInterop.call.void.1ArgsInt(RunTimeRaw): 0.018 ns. After: WasmJSInterop.call.void.1ArgsSmi(RunTimeRaw): 0.014 ns. WasmJSInterop.call.void.1ArgsInt(RunTimeRaw): 0.018 ns. Issue: https://github.com/dart-lang/sdk/issues/60357 Change-Id: I749001e0e7e9784114415439298c2f3e0fb974b3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/419880 Commit-Queue: Ömer Ağacan <omersa@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com> https://dart.googlesource.com/sdk/+/6952a8097885abac038a262aa42563b38b189415
Monorepo is:
With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:
mkdir monorepo cd monorepo gclient config --unmanaged https://dart.googlesource.com/monorepo gclient sync -D
This gives you a checkout in the monorepo directory that contains:
monorepo/ DEPS - the DEPS used for this gclient checkout commits.json - the pinned commits for Dart, flutter/engine, and flutter/flutter tools/ - scripts used to create monorepo DEPS engine/src/ - the flutter/buildroot repo flutter/ - the flutter/engine repo out/ - the build directory, where Flutter engine builds are created third_party/ - Flutter dependencies checked out by DEPS dart/ - the Dart SDK checkout. third_party - Dart dependencies, also used by Flutter flutter/ - the flutter/flutter repo
Flutter's instructions for building the engine are at Compiling the engine
They can be followed closely, with a few changes:
goma_ctl ensure_start
is sufficient.Example build commands that work on linux:
MONOREPO_PATH=$PWD if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then PATH=$MONOREPO_PATH/flutter/bin:$PATH fi export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin goma_ctl ensure_start pushd engine/src flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk autoninja -C out/host_debug_unopt popd
The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine
option is provided.
For example, to build and run the Flutter spinning square sample on the web platform,
MONOREPO_PATH=$PWD cd flutter/examples/layers flutter --local-engine=host_debug_unopt \ -d chrome run widgets/spinning_square.dart cd $MONOREPO_PATH
To build for desktop, specify the desktop platform device in flutter run
as -d macos
or -d linux
or -d windows
. You may also need to run the command
flutter create --platforms=windows,macos,linux
on existing apps, such as sample apps. New apps created with flutter create
already include these support files. Details of desktop support are at Desktop Support for Flutter
Tests in the Flutter source tree can be run with the flutter test
command, run in the directory of a package containing tests. For example:
MONOREPO_PATH=$PWD cd flutter/packages/flutter flutter test --local-engine=host_debug_unopt cd $MONOREPO_PATH
Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.
We will update this documentation to address them.
flutter
commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.gclient sync
needs to be run in an administrator session, because some installed dependencies create symlinks.