Revert #160653 Fix view removal process for AutofillContextAction.cancel (#172490) Between #145681 (autofill save prompt shows up for password fields when you dismiss the keyboard) and #172250 (calling `TextInput.hide` causes the current active text field to lose its text) the latter seems to be the worse bug. The framework `EditableText` implementation only calls `TextInput.hide` when switching input controls, so #172250 typically does not affect flutter text fields itself, but becomes a problem if the app wishes to add UI (similar to the iOS down-arrow button that would show up above the keyboard when you're filling out a form) to dismiss the keyboard. This reopens #145681. See https://github.com/flutter/flutter/issues/145681#issuecomment-3098865633 @koji-1009 does reverting sound ok to you? ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md https://dart.googlesource.com/external/github.com/flutter/flutter/+/be9526fbaaaab9474e95d196b70c41297eeda2d0
diff --git a/DEPS b/DEPS index 4e5dc3a..5a068bc 100644 --- a/DEPS +++ b/DEPS
@@ -231,7 +231,7 @@ deps = { 'flutter/engine/src/flutter/third_party/dart': Var('dart_git') + '/sdk' + '@' + '58c09c24edf11ebfe90b5c3cd0e2648491ea35c9', - 'flutter': Var('flutter_git') + '/mirrors/flutter' + '@' + '6b7d92852c492f601884c2da3f3cc586b4fb32fc', + 'flutter': Var('flutter_git') + '/mirrors/flutter' + '@' + 'be9526fbaaaab9474e95d196b70c41297eeda2d0', 'flutter/engine/src/flutter/third_party/depot_tools': Var('chromium_git') + '/chromium/tools/depot_tools.git' + '@' + '580b4ff3f5cd0dcaa2eacda28cefe0f45320e8f7',
diff --git a/commits.json b/commits.json index 8c193ec..cf1e4d8 100644 --- a/commits.json +++ b/commits.json
@@ -1,4 +1,4 @@ { - "flutter":"6b7d92852c492f601884c2da3f3cc586b4fb32fc", + "flutter":"be9526fbaaaab9474e95d196b70c41297eeda2d0", "flutter/engine/src/flutter/third_party/dart":"58c09c24edf11ebfe90b5c3cd0e2648491ea35c9" } \ No newline at end of file