commit	3f22194581828f08202da8f6082bd0075330c5dd	[log] [tgz]
author	skia-flutter-autoroll <skia-flutter-autoroll@skia.org>	Mon Oct 21 20:28:20 2024 -0400
committer	dart-internal-monorepo <dart-internal-monorepo@dart-ci-internal.iam.gserviceaccount.com>	Mon Oct 21 17:36:11 2024 -0700
tree	df1c2ab6c1ccff81db1e4a91ebe4a05efcff0013
parent	53f5a061baa2ae45cce6478e9022c219d84b9f47 [diff]

Roll Skia from 3a081993e2a7 to a71df7d9bc63 (24 revisions) (#56005)

https://skia.googlesource.com/skia.git/+log/3a081993e2a7..a71df7d9bc63

2024-10-21 arthursonzogni@chromium.org partition_alloc: Fix condition about sanitizers.
2024-10-21 robertphillips@google.com [graphite] Address Native-Vulkan Precompilation thread races
2024-10-21 robertphillips@google.com [graphite] Add test for precompilation thread safety
2024-10-21 double1kai@gmail.com fix some bugs in type conversion on Loongarch
2024-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 1ea770ceed23 to 4220684adef5 (1 revision)
2024-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 4b1e58d94333 to 4aa12e9e17f5 (6 revisions)
2024-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e81b15c8854a to 6c65601e5d77 (2 revisions)
2024-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 7e8a128852ff to 6a645bf6ebd6 (12 revisions)
2024-10-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7acb8149138a to 1ea770ceed23 (9 revisions)
2024-10-19 lukasza@chromium.org [rust png] Enable and fix integer conversion warnings.
2024-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b48b5be748a7 to 7acb8149138a (7 revisions)
2024-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2f644ed8a84e to 4b1e58d94333 (7 revisions)
2024-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 06128ba913e9 to b48b5be748a7 (2 revisions)
2024-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 4c14e8e4f022 to 7e8a128852ff (17 revisions)
2024-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 70e3e4feed08 to e81b15c8854a (1 revision)
2024-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 74b783dffb9b to 0afe6a306dd2 (1 revision)
2024-10-17 vigneshv@google.com crabbyavif: Add support for cropping
2024-10-17 michaelludwig@google.com [graphite] ShaderInfo::toSkSL() release asserts
2024-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from bd3c30184daf to 06128ba913e9 (2 revisions)
2024-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0dbe85f31776 to 2f644ed8a84e (15 revisions)
2024-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 78ae0bf49048 to 70e3e4feed08 (3 revisions)
2024-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 65fa98d50f6d to 4c14e8e4f022 (10 revisions)
2024-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ad31dd1cb898 to bd3c30184daf (11 revisions)
2024-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 6a07fae851d7 to a049ff55ff14

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://dart.googlesource.com/external/github.com/flutter/engine/+/633d39211ffd9f8f11454aa16a4dcff4f56389b7

2 files changed

tree: df1c2ab6c1ccff81db1e4a91ebe4a05efcff0013

README.md

Monorepo

A gclient solution for checking out Dart and Flutter source trees

Monorepo is:

Optimized for Tip-of-Tree testing: The Monorepo DEPS used to check out Dart and Flutter dependencies comes from the Flutter engine DEPS with updated dependencies from Dart.

Checking out Monorepo

With depot_tools installed and on your path, create a directory for your monorepo checkout and run these commands to create a gclient solution in that directory:

mkdir monorepo
cd monorepo
gclient config --unmanaged https://dart.googlesource.com/monorepo
gclient sync -D

This gives you a checkout in the monorepo directory that contains:

monorepo/
  DEPS - the DEPS used for this gclient checkout
  commits.json - the pinned commits for Dart, flutter/engine,
                 and flutter/flutter
  tools/ - scripts used to create monorepo DEPS
engine/src/ - the flutter/buildroot repo
    flutter/ - the flutter/engine repo
    out/ - the build directory, where Flutter engine builds are created
    third_party/ - Flutter dependencies checked out by DEPS
      dart/ - the Dart SDK checkout.
        third_party - Dart dependencies, also used by Flutter
flutter/ - the flutter/flutter repo

Building Flutter engine

Flutter's instructions for building the engine are at Compiling the engine

They can be followed closely, with a few changes:

Googlers working on Dart do not need to switch to Fuchsia's Goma RBE, except for Windows. The GOMA_DIR enviroment variable can just point to the .cipd_bin directory in a depot_tools installation, and just goma_ctl ensure_start is sufficient.
The --no-prebuilt-dart-sdk option has to be added to every gn command, so that the build is set up to build and use a local Dart SDK.
The --full-dart-sdk option must be added to gn for the host build target if you will be building web or desktop apps.

Example build commands that work on linux:

MONOREPO_PATH=$PWD
if [[ ! $PATH =~ (^|:)$MONOREPO_PATH/flutter/bin(:|$) ]]; then
  PATH=$MONOREPO_PATH/flutter/bin:$PATH
fi

export GOMA_DIR=$(dirname $(command -v gclient))/.cipd_bin
goma_ctl ensure_start

pushd engine/src
flutter/tools/gn --goma --no-prebuilt-dart-sdk --unoptimized --full-dart-sdk
autoninja -C out/host_debug_unopt
popd

Building Flutter apps

The Flutter commands used to build and run apps will use the locally built Flutter engine and Dart SDK, instead of the one downloaded by the Flutter tool, if the --local-engine option is provided.

For example, to build and run the Flutter spinning square sample on the web platform,

MONOREPO_PATH=$PWD
cd flutter/examples/layers
flutter --local-engine=host_debug_unopt \
  -d chrome run widgets/spinning_square.dart
cd $MONOREPO_PATH

To build for desktop, specify the desktop platform device in flutter run as -d macos or -d linux or -d windows. You may also need to run the command

flutter create --platforms=windows,macos,linux

on existing apps, such as sample apps. New apps created with flutter create already include these support files. Details of desktop support are at Desktop Support for Flutter

Testing

Tests in the Flutter source tree can be run with the flutter test command, run in the directory of a package containing tests. For example:

MONOREPO_PATH=$PWD
cd flutter/packages/flutter
flutter test --local-engine=host_debug_unopt
cd $MONOREPO_PATH

Troubleshooting

Please file an issue or email the dart-engprod team with any problems with or questions about using monorepo.

We will update this documentation to address them.

flutter commands may download the engine and Dart SDK files for the configured channel, even though they will be using the local engine and its SDK.

Windows

On Windows, gclient sync needs to be run in an administrator session, because some installed dependencies create symlinks.